Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Multiple issues #60

Merged
merged 5 commits into from
Sep 27, 2019
Merged

fix: Multiple issues #60

merged 5 commits into from
Sep 27, 2019

Conversation

tassoevan
Copy link
Collaborator

@tassoevan tassoevan commented Sep 27, 2019 •
edited
Loading

  • Remove unused dependencies
  • Update Storybook, ESLint and other dependencies
  • Mark styled-components as a peer dependency
  • Fix Label for position='start' for position='end'
  • Fix color for <Input type='select'> when placeholder prop is set

@tassoevan tassoevan added the 🐛 Bug Something isn't working label Sep 27, 2019
@tassoevan tassoevan requested a review from ggazzo September 27, 2019 18:33
@tassoevan tassoevan marked this pull request as ready for review September 27, 2019 19:08
@ggazzo ggazzo changed the title [FIX] Multiple issues fix: Multiple issues Sep 27, 2019
@ggazzo ggazzo merged commit 62e5620 into develop Sep 27, 2019
@ggazzo ggazzo deleted the fix/multiple-issues branch September 27, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@MartinSchoeler MartinSchoeler Awaiting requested review from MartinSchoeler

Assignees
No one assigned
Labels
🐛 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tassoevan @ggazzo