Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dismissKey param in closeAlert of LuigiContainer should be optional #4103

Closed
JohannesDoberer opened this issue Jan 8, 2025 · 0 comments · Fixed by #4106
Closed

dismissKey param in closeAlert of LuigiContainer should be optional #4103

JohannesDoberer opened this issue Jan 8, 2025 · 0 comments · Fixed by #4106
Assignees
@JohannesDoberer
Labels
bug Something isn't working

Comments

@JohannesDoberer
Copy link
Contributor

https://github.com/SAP/luigi/blob/main/container/src/LuigiContainer.svelte#L148
@JohannesDoberer JohannesDoberer added the bug Something isn't working label Jan 8, 2025
@JohannesDoberer JohannesDoberer self-assigned this Jan 9, 2025
@JohannesDoberer JohannesDoberer changed the title dismiss param in closeAlert of LuigiContainer should be optional dismissKey param in closeAlert of LuigiContainer should be optional Jan 9, 2025
@walmazacn walmazacn linked a pull request Jan 17, 2025 that will close this issue
dismissKey optional in closeAlert #4106
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohannesDoberer JohannesDoberer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dismissKey optional in closeAlert SAP/luigi
2 participants
@JohannesDoberer @walmazacn