Skip to content

Commit 208e584

Browse files
authored
[rb] Linting Updates (#2297)
* [rb] Linting Updates * rest of offenses * renable RSpec/MultipleDescribes after disabling * oops
1 parent 6a7303a commit 208e584

File tree

8 files changed

+20
-5
lines changed

8 files changed

+20
-5
lines changed

examples/ruby/spec/bidi/logging_spec.rb

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
require 'spec_helper'
24

35
RSpec.describe 'Logging' do

examples/ruby/spec/browsers/chrome_spec.rb

+2-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,8 @@
131131
'offline' => false,
132132
'latency' => 100,
133133
'download_throughput' => 200,
134-
'upload_throughput' => 200)
134+
'upload_throughput' => 200
135+
)
135136
end
136137

137138
it 'gets the browser logs' do

examples/ruby/spec/browsers/edge_spec.rb

+3-2
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,8 @@
131131
'offline' => false,
132132
'latency' => 100,
133133
'download_throughput' => 200,
134-
'upload_throughput' => 200)
134+
'upload_throughput' => 200
135+
)
135136
end
136137

137138
it 'gets the browser logs' do
@@ -164,6 +165,6 @@ def driver_finder
164165

165166
def permission(name)
166167
@driver.execute_async_script('callback = arguments[arguments.length - 1];' \
167-
'callback(navigator.permissions.query({name: arguments[0]}));', name)['state']
168+
'callback(navigator.permissions.query({name: arguments[0]}));', name)['state']
168169
end
169170
end

examples/ruby/spec/browsers/safari_spec.rb

+5-2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
require 'spec_helper'
44

5+
# rubocop:disable RSpec/MultipleDescribes
56
RSpec.describe 'Safari', exclusive: {platform: :macosx} do
67
describe 'Options' do
78
it 'basic options' do
@@ -33,10 +34,12 @@
3334
end
3435
end
3536

36-
RSpec.describe 'Safari Technology Preview', skip: "This test is being skipped as GitHub Actions have no support for Safari Technology Preview" do
37+
RSpec.describe 'Safari Technology Preview', skip: 'This test is being skipped as GitHub Actions ' \
38+
'have no support for Safari Technology Preview' do
3739
it 'sets the technology preview' do
3840
Selenium::WebDriver::Safari.technology_preview!
3941
local_driver = Selenium::WebDriver.for :safari
4042
expect(local_driver.capabilities.browser_name).to eq 'Safari Technology Preview'
4143
end
42-
end
44+
end
45+
# rubocop:enable RSpec/MultipleDescribes

examples/ruby/spec/drivers/http_client_spec.rb

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
require 'spec_helper'
24

35
RSpec.describe 'HTTP Client' do

examples/ruby/spec/hello/hello_selenium.rb

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
require 'selenium-webdriver'
24

35
driver = Selenium::WebDriver.for :chrome

examples/ruby/spec/interactions/browser_spec.rb

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
require 'spec_helper'
24

35
RSpec.describe 'Browser' do

examples/ruby/spec/interactions/navigation_spec.rb

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
require 'spec_helper'
24

35
RSpec.describe 'Browser' do

0 commit comments

Comments
 (0)