Skip to content

fix: avoid returning view for generic operators #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025

Conversation

MilesCranmer
Copy link
Member

No description provided.

@MilesCranmer MilesCranmer enabled auto-merge April 29, 2025 10:13
@coveralls
Copy link

coveralls commented Apr 29, 2025

Pull Request Test Coverage Report for Build 14729128842

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.578%

Totals Coverage Status
Change from base Build 13595867267: 0.0%
Covered Lines: 2572
Relevant Lines: 2691

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Apr 29, 2025

Benchmark Results

master cc589e5... master / cc589e5...
eval/ComplexF32/evaluation 7.25 ± 0.52 ms 7.29 ± 0.62 ms 0.994
eval/ComplexF64/evaluation 10.8 ± 0.94 ms 10.9 ± 1.1 ms 0.986
eval/Float32/derivative 11.9 ± 0.74 ms 12.4 ± 0.86 ms 0.965
eval/Float32/derivative_turbo 11.9 ± 0.69 ms 12.3 ± 0.94 ms 0.961
eval/Float32/evaluation 2.73 ± 0.27 ms 2.72 ± 0.27 ms 1
eval/Float32/evaluation_bumper 0.599 ± 0.015 ms 0.603 ± 0.016 ms 0.995
eval/Float32/evaluation_turbo 0.51 ± 0.029 ms 0.541 ± 0.031 ms 0.944
eval/Float32/evaluation_turbo_bumper 0.6 ± 0.015 ms 0.602 ± 0.016 ms 0.996
eval/Float64/derivative 15 ± 1.6 ms 15.7 ± 1.5 ms 0.954
eval/Float64/derivative_turbo 14.8 ± 1.4 ms 15.8 ± 1.7 ms 0.936
eval/Float64/evaluation 3.11 ± 0.34 ms 3.18 ± 0.33 ms 0.977
eval/Float64/evaluation_bumper 1.25 ± 0.042 ms 1.26 ± 0.044 ms 0.99
eval/Float64/evaluation_turbo 1.02 ± 0.066 ms 1.05 ± 0.064 ms 0.969
eval/Float64/evaluation_turbo_bumper 1.24 ± 0.043 ms 1.25 ± 0.042 ms 0.992
utils/combine_operators/break_sharing 0.0389 ± 0.00078 ms 0.0396 ± 0.0012 ms 0.982
utils/convert/break_sharing 28 ± 3.1 μs 27.1 ± 3 μs 1.03
utils/convert/preserve_sharing 0.104 ± 0.0068 ms 0.103 ± 0.0066 ms 1.01
utils/copy/break_sharing 28.2 ± 2.3 μs 28.3 ± 2.3 μs 0.999
utils/copy/preserve_sharing 0.102 ± 0.0051 ms 0.0999 ± 0.0055 ms 1.02
utils/count_constant_nodes/break_sharing 8.47 ± 0.28 μs 8.5 ± 0.29 μs 0.997
utils/count_constant_nodes/preserve_sharing 0.0897 ± 0.0064 ms 0.0879 ± 0.0057 ms 1.02
utils/count_depth/break_sharing 9.32 ± 0.24 μs 10.1 ± 0.34 μs 0.926
utils/count_nodes/break_sharing 8.6 ± 0.24 μs 8.59 ± 0.28 μs 1
utils/count_nodes/preserve_sharing 0.0894 ± 0.006 ms 0.0877 ± 0.0057 ms 1.02
utils/get_set_constants!/break_sharing 0.034 ± 0.002 ms 0.0342 ± 0.002 ms 0.992
utils/get_set_constants!/preserve_sharing 0.181 ± 0.0097 ms 0.181 ± 0.0099 ms 1
utils/get_set_constants_parametric 0.0456 ± 0.0029 ms 0.0469 ± 0.0027 ms 0.971
utils/has_constants/break_sharing 4.64 ± 0.18 μs 4.44 ± 0.2 μs 1.05
utils/has_operators/break_sharing 1.76 ± 0.076 μs 2.36 ± 0.096 μs 0.745
utils/hash/break_sharing 23.5 ± 0.72 μs 23.6 ± 0.81 μs 0.994
utils/hash/preserve_sharing 0.102 ± 0.0064 ms 0.0994 ± 0.0062 ms 1.02
utils/index_constant_nodes/break_sharing 26.2 ± 1.3 μs 25.5 ± 1.3 μs 1.03
utils/index_constant_nodes/preserve_sharing 0.103 ± 0.0066 ms 0.105 ± 0.0064 ms 0.981
utils/is_constant/break_sharing 4.25 ± 0.18 μs 4.19 ± 0.2 μs 1.01
utils/simplify_tree/break_sharing 0.169 ± 0.0053 ms 0.169 ± 0.0067 ms 1
utils/simplify_tree/preserve_sharing 0.222 ± 0.011 ms 0.227 ± 0.011 ms 0.977
utils/string_tree/break_sharing 0.493 ± 0.02 ms 0.48 ± 0.02 ms 1.03
utils/string_tree/preserve_sharing 0.608 ± 0.026 ms 0.587 ± 0.027 ms 1.04
time_to_load 0.222 ± 0.0056 s 0.228 ± 0.0053 s 0.972

@MilesCranmer MilesCranmer disabled auto-merge April 29, 2025 10:42
@MilesCranmer MilesCranmer merged commit 605e111 into master Apr 29, 2025
12 checks passed
@MilesCranmer MilesCranmer deleted the fix-generic-views branch April 29, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants