Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music Not stopping #6

Open
SlaydeSequeira opened this issue Oct 1, 2024 · 5 comments
Open

Music Not stopping #6

SlaydeSequeira opened this issue Oct 1, 2024 · 5 comments
Labels
enhancement New feature or request hacktoberfest

Comments

@SlaydeSequeira
Copy link

Im using a redmi 11i and after i close the app and even swipe the app or even clear cache the music won't stop, i need to force stop it everytime. I think the function to stop it should be called in on pause aswell as on destroy and on back pressed.

@TangoBeee
Copy link
Owner

Hi @SlaydeSequeira,

Thanks for your feedback! The behavior you’re experiencing isn’t considered a bug, as the app is designed to allow background play, meaning the music will continue even after you close the app. However, I understand that some users may prefer to have the option to pause or stop the music easily.

We can certainly look into adding an option in the device notification to control the music playback. Would you be interested in working on this feature?

Let me know what you think!

@TangoBeee TangoBeee added enhancement New feature or request hacktoberfest labels Oct 1, 2024
@singhDevs
Copy link

We can instead provide it as a feature in Settings fragment of the app. The user can enable/disable the music playback even when the app is removed from the background. I can work on this.

@SlaydeSequeira
Copy link
Author

SlaydeSequeira commented Oct 2, 2024

@singhDevs the settings already has an enable/disable if I'm not mistaken, what i was thinking @TangoBeee is we add a media notifications on top kinda how spotify has a pause button to stop music or play next song without opening the app.

@singhDevs
Copy link

@SlaydeSequeira so i looked up the settings of the app which has a toggle button to enable/disable the Weather music. What I suggest is instead of having a toggle button, we can have a pop up menu with options like:

  • Disable weather music
  • Enable weather music but don't play when the app is in background.
  • Enable weather music and keep playing in the background

This way we can address the weather music setting at one place without the need of creating another setting option.
Also, regarding the notification idea, do we really need to allow the user to play/pause the music anytime? If not, then the above solution would work. If we need to play/pause music, then implementing the notification could be a great idea.

@SlaydeSequeira
Copy link
Author

I have implemented a notification bar to do that now and sent @TangoBeee a pull request let's see if he needs further enhancements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants