Merge pull request #297 from ishuar/ux/fix-trailing-slash

Chemaclass · web-flow · commit 018390edca51 · 2024-07-17T09:13:02.000+02:00
fix: Double `/` on Running script
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@
 
 - Add assertions to log file
 
+- Improve UX by Removing trailing slashes `/` from the test directories naming output.
+
 ## [0.14.0](https://github.com/TypedDevs/bashunit/compare/0.13.0...0.14.0) - 2024-07-14
 
 - Fix echo does not break test execution results
diff --git a/src/helpers.sh b/src/helpers.sh
@@ -86,7 +86,8 @@ function helper::unset_if_exists() {
 }
 
 function helper::find_files_recursive() {
-  local path="$1"
+  ## Remove trailing slash using parameter expansion
+  local path="${1%%/}"
 
   if [[ "$path" == *"*"* ]]; then
     eval find "$path" -type f -name '*[tT]est.sh' | sort | uniq

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,8 @@ function helper::unset_if_exists() {`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`function helper::find_files_recursive() {`
`89`		`- local path="$1"`
	`89`	`+ ## Remove trailing slash using parameter expansion`
	`90`	`+ local path="${1%%/}"`
`90`	`91`
`91`	`92`	`if [[ "$path" == ""* ]]; then`
`92`	`93`	`eval find "$path" -type f -name '*[tT]est.sh' \| sort \| uniq`