Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies #164

Closed
lesserwhirls opened this issue Oct 31, 2017 · 7 comments
Closed

Dependencies #164

lesserwhirls opened this issue Oct 31, 2017 · 7 comments

Comments

@lesserwhirls
Copy link
Collaborator

Currently the dependency list in README.rst is out of sync with setup.py. For example, README.rst has:

requests>=1.2
numpy>=1.8
protobuf>=3.0.0a3

while setup.py has these additional deps:

beautifulsoup4>=4.6
pandas

Easy fix, but I wonder if there is an easier way to keep these lists in sync, or do we need to hand maintain the two dependency lists?

Also, pandas is missing from environment.yml. There could also be other differences between setup.py and environment.yml, as I didn't do a thorough combing because I wanted to see if there was a way we could reduce the duplication first.

@lesserwhirls
Copy link
Collaborator Author

The install guide and developers guide are also out of sync with setup.py.

@lesserwhirls
Copy link
Collaborator Author

We could always make all three of us a file owner on setup.py, so that potential change to the deps would have to be reviewed by all of us, therefore increasing the likelihood that we'd also check the other places deps are listed?

@dopplershift
Copy link
Member

The only way I can think of automating/eliminating repetition is to use a requirements file that somehow gets embedded into the appropriate doc page (not even sure if that's baked into sphinx). environment.yml will always be its own thing.

@jrleeman
Copy link
Contributor

jrleeman commented Nov 1, 2017

Checklists or a script that compares all of these and fails the build?

@dopplershift
Copy link
Member

While I'm all for automation, that feels like there are many hours hiding in getting that in place--essentially in just making sure the docs stay up to date. setup.py and environment.yml are "guaranteed" to be correct because they're used on Travis and AppVeyor, respectively.

I'm a little disturbed that windows builds are working without pandas being listed, but I wonder if pandas is getting pulled in as a dep for something else (xarray?).

@jrleeman
Copy link
Contributor

jrleeman commented Nov 1, 2017

Must be - it is a listed dep: http://xarray.pydata.org/en/stable/installing.html

@dopplershift
Copy link
Member

#810 switched us over to include (now) pyproject.toml directly in the install guide.

@dopplershift dopplershift added this to the 0.10 milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants