Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

futurereserve #33

Open
5 tasks done
VincyaneBadouard opened this issue Jul 23, 2021 · 1 comment
Open
5 tasks done

futurereserve #33

VincyaneBadouard opened this issue Jul 23, 2021 · 1 comment
Labels
dev

Comments

@VincyaneBadouard
Copy link
Owner

VincyaneBadouard commented Jul 23, 2021 •
edited by GeraldineDerroire
Loading

  • code
  • test
  • document (V0)
  • Sylvain's check (code)
  • Geraldine check (doc)
@sylvainschmitt
Copy link
Collaborator

The code is very simple so I have nothing else to say than congrats! The test is taking 2s (>1s) which seems a lot for a simple function. Once again you can reduce it by using sample_n on the inventory and adjusting VO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sylvainschmitt @VincyaneBadouard