Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONFGuyafortaxojoin #34

Open
5 tasks done
VincyaneBadouard opened this issue Jul 23, 2021 · 1 comment
Open
5 tasks done

ONFGuyafortaxojoin #34

VincyaneBadouard opened this issue Jul 23, 2021 · 1 comment
Labels

Comments

@VincyaneBadouard
Copy link
Owner

VincyaneBadouard commented Jul 23, 2021

  • code
  • test
  • document (V0)
  • Sylvain's check (code)
  • Geraldine check (doc)
@sylvainschmitt
Copy link
Collaborator

sylvainschmitt commented Jul 23, 2021

  • check the existence of the columns you need in species criteria
  • 80 characters lines
  • the species corrections are very specific to FG
  • maybe reduce the size of the inventory to accelerate the test

Everything else is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants