Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aliases and the auto completions #507

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

waitingsong
Copy link
Contributor

@waitingsong waitingsong commented Feb 8, 2025

  1. feat: add docker aliases and the auto completions
    • dcc='docker container'
    • dii='docker image inspect'
    • diis='docker image inspect -f "Id:{{.Id}} {{println}}\
    • dps='docker ps --format "table {{.Image}}\t{{.Command}}\t{{.RunningFor}}\t{{.Status}}\t{{.Names}}\t{{.Mounts}}"'
    • dv='docker volume'
    • additional completion for d

roles/node/files/docker download from https://raw.githubusercontent.com/docker/cli/master/contrib/completion/bash/docker , hash: dbc5cf6

  1. feat: add auto completions for systemctl and sub commands

    • status
    • restart
    • additional completion for s
  2. feat: add auto completions for ju alias of journalctl -u

@waitingsong waitingsong force-pushed the docker-auto-completion branch 3 times, most recently from 968b21d to aaaca8d Compare February 8, 2025 08:23
- dcc='docker container'
- dii='docker image inspect'
- diis='docker image inspect -f "Id:{{.Id}} {{println}}\
- dps='docker ps --format "table {{.Image}}\t{{.Command}}\t{{.RunningFor}}\t{{.Status}}\t{{.Names}}\t{{.Mounts}}"'
- dv='docker volume'

roles/node/files/docker download from https://raw.githubusercontent.com/docker/cli/master/contrib/completion/bash/docker , hash: dbc5cf6
@waitingsong waitingsong force-pushed the docker-auto-completion branch from c7627f9 to bb68b6d Compare February 8, 2025 15:08
@waitingsong waitingsong changed the title feat: add docker aliases and the auto completions feat: add aliases and the auto completions Feb 8, 2025
@Vonng
Copy link
Member

Vonng commented Feb 14, 2025

I thought about it, and while adding too many aliases may be convenient, it can lead to confusion. A better approach would be to add a node_alias parameter, allowing users to pass in and define any alias they want to use. Therefore, this PR might be resolved in another way.

@Vonng Vonng merged commit 7104af9 into pgsty:main Feb 16, 2025
1 check passed
@waitingsong waitingsong deleted the docker-auto-completion branch February 16, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants