Switch Calloc,Free to R_Calloc,R_Free for STRICT_R_HEADERS #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Chuyi, dear biglasso team,
Your CRAN package biglasso uses Rcpp, and is affected if we add a definition of STRICT_R_HEADERS as we would like to do. Please see the discussion at RcppCore/Rcpp#1158 and the links therein for more context on this.
Here, we can prefix each #include <Rcpp.h> with STRICT_R_HEADERS, or we can also define it in src/Makevars* for a more minimal changeset via -DSTRICT_R_HEADERS, or as I currently do add in the Rcpp headers. Defining it means
Calloc()
andFree()
are no longer "visible" as the more defensively namedR_Calloc()
andR_Free()
are preferred. The simple PR just renames them in four files.We plan to enable STRICT_R_HEADERS by the Jan 2022 release of Rcpp, and will likely offer you a define to suppress it. So if you really do not want the change you can prevent it -- see these lines in Rcpp for details:
https://github.com/RcppCore/Rcpp/blob/e79c70e76bc2a776d2d57287f7192dbdbcb292aa/inst/include/Rcpp/r/headers.h#L28-L38
It would be lovely if you could apply this. There is no strong urgency: we aim to get this done over all affected packages in the space of a few months. If you apply it, would you mind dropping me a note by email or swinging by RcppCore/Rcpp#1158 to confirm?
Please don't hesitate to ask (here, at RcppCore/Rcpp#1158, or via email) if you have any questions.
Many thanks for your help, and I hope you continue to find Rcpp helpful.