Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tree/Table/etc test utils to handle selectionBehavior="replace" #7884

Open
LFDanLu opened this issue Mar 6, 2025 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@LFDanLu
Copy link
Member

LFDanLu commented Mar 6, 2025

Provide a general summary of the feature here

At the moment, the test utils for selectable collection components have most of their selection interactions based off "toggle" selection. This user flows don't work as well for "replace" selection due to behavior differences, primarily around the fact that "replace" will replace selection on click and focus change, requiring the use of modifier keys to properly append to the current selection. Some work has been done in the support_highlight_selection branch, but updated user flows still need to be implemented

🤔 Expected Behavior?

tester methods like toggleRowSelection should support a separate option for selectionBehavior to support the alternative selection behaviors described here: https://react-spectrum.adobe.com/react-aria/Tree.html#selection-behavior

😯 Current Behavior

tester methods primarily support just "toggle" selection

💁 Possible Solution

No response

🔦 Context

This has hindered writing tests against "highlightSelection" TreeViews

💻 Examples

No response

🧢 Your Company/Team

RSP

🕷 Tracking Issue

No response

@github-project-automation github-project-automation bot moved this to 🩺 To Triage in RSP Component Milestones Mar 6, 2025
@LFDanLu LFDanLu moved this from 🩺 To Triage to 📋 Waiting for Sprint in RSP Component Milestones Mar 6, 2025
@LFDanLu LFDanLu added the enhancement New feature or request label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Waiting for Sprint
Development

No branches or pull requests

1 participant