Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help request: remove useless code #12041

Closed
nic-chen opened this issue Mar 12, 2025 · 0 comments
Closed

help request: remove useless code #12041

nic-chen opened this issue Mar 12, 2025 · 0 comments
Labels

Comments

@nic-chen
Copy link
Member

Description

These lines of code (https://github.com/apache/apisix/blob/master/apisix/utils/log-util.lua#L359-L361) are meaningless and have no effect, because before core.response.hold_body_chunk is executed, ctx._resp_body_bytes is nil and will not continue to execute and return.

Environment

  • APISIX version (run apisix version): master
  • Operating system (run uname -a):
  • OpenResty / Nginx version (run openresty -V or nginx -V):
  • etcd version, if relevant (run curl http://127.0.0.1:9090/v1/server_info):
  • APISIX Dashboard version, if relevant:
  • Plugin runner version, for issues related to plugin runners:
  • LuaRocks version, for installation issues (run luarocks --version):
@nic-chen nic-chen added the good first issue Good for newcomers label Mar 12, 2025
@dosubot dosubot bot added the tech debt label Mar 12, 2025
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Apache APISIX backlog Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

1 participant