-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] Add checkstyle for CI #1513
Comments
Strongly +1. Static analysis might produce false positives, but overall I think it is better than not having it. |
Suggestions are expected to be reported to the mailing list dev@incubator.dubbo.apache.org. Issues are used to track bugs. |
@ralf0131 sure thing. next time I will send suggestion to maillist |
Apache runs SonarQube if you want to use that. See https://builds.apache.org/analysis/ |
I did a quick try. I only apply one basic rule.
Checkstyle find more than 6000 Checkstyle violations :( |
hey team,
I notice there is some unused code (for example: https://github.com/apache/incubator-dubbo/blob/master/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/Hessian2Input.java#L88)
Looks like dubbo doesn't have checkstyle in maven configuration or it doesn't have correct rule.
do we have any plan to add checkstyle check in CI?
The text was updated successfully, but these errors were encountered: