Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Add checkstyle for CI #1513

Closed
htynkn opened this issue Mar 26, 2018 · 5 comments · Fixed by #1558
Closed

[Suggestion] Add checkstyle for CI #1513

htynkn opened this issue Mar 26, 2018 · 5 comments · Fixed by #1558

Comments

@htynkn
Copy link
Member

htynkn commented Mar 26, 2018

hey team,

I notice there is some unused code (for example: https://github.com/apache/incubator-dubbo/blob/master/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/Hessian2Input.java#L88)

Looks like dubbo doesn't have checkstyle in maven configuration or it doesn't have correct rule.

do we have any plan to add checkstyle check in CI?

@htynkn htynkn changed the title Add checkstyle for CI [Suggestion] Add checkstyle for CI Mar 26, 2018
@ralf0131
Copy link
Contributor

Strongly +1. Static analysis might produce false positives, but overall I think it is better than not having it.

@ralf0131
Copy link
Contributor

Suggestions are expected to be reported to the mailing list dev@incubator.dubbo.apache.org. Issues are used to track bugs.

@htynkn
Copy link
Member Author

htynkn commented Mar 27, 2018

@ralf0131 sure thing. next time I will send suggestion to maillist

@justinmclean
Copy link
Member

Apache runs SonarQube if you want to use that. See https://builds.apache.org/analysis/

@htynkn
Copy link
Member Author

htynkn commented Apr 5, 2018

I did a quick try. I only apply one basic rule.
According to dubbo code-conventions.

If there are more than 120 characters in current line, start a new line.

Checkstyle find more than 6000 Checkstyle violations :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants