Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] FluentLoggerImpl doesn't record the code line number of the calling class, and just record its own calling time #15240

Open
3 of 4 tasks
zrlw opened this issue Mar 14, 2025 · 1 comment
Assignees
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage

Comments

@zrlw
Copy link
Contributor

zrlw commented Mar 14, 2025

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar issues.

Apache Dubbo Component

Java SDK (apache/dubbo)

Dubbo Version

Dubbo 3.3

Steps to reproduce this issue

the delegate of FluentLoggerImpl is org.apache.dubbo.common.logger.slf4j.Slf4jLogger, which has already set FQCN, so the code line numbers that FluentLoggerImpl outputs are all his own.
Image
the timestamp recorded by FluentLoggerImpl does not correspond to the actual time when the application generated the logs. it is just the time when FluentLoggerImpl called the logger agent.This may cause inconsistencies in timestamp alignment between client and server logs, make it challenging to determine the chronological order of interactions between the client and server.

What you expected to happen

the code line number of log info should be the code line number of the calling class.

Anything else

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@zrlw zrlw added component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage labels Mar 14, 2025
@zrlw
Copy link
Contributor Author

zrlw commented Mar 14, 2025

@oxsean PTAL

@oxsean oxsean self-assigned this Mar 14, 2025
@zrlw zrlw changed the title [Bug] FluentLoggerImpl desn't output the code line number of the calling class [Bug] FluentLoggerImpl doesn't output the code line number of the calling class Mar 19, 2025
@zrlw zrlw changed the title [Bug] FluentLoggerImpl doesn't output the code line number of the calling class [Bug] FluentLoggerImpl doesn't record the code line number of the calling class, and just record itself calling time Mar 22, 2025
@zrlw zrlw changed the title [Bug] FluentLoggerImpl doesn't record the code line number of the calling class, and just record itself calling time [Bug] FluentLoggerImpl doesn't record the code line number of the calling class, and just record its own calling time Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage
Projects
Status: Todo
Development

No branches or pull requests

2 participants