Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-8981][VL] Add vcpkg triplet for building Gluten on arm #8982

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zmdaodao
Copy link

What changes were proposed in this pull request?

fixed #8981

And fixed “Environment variable VCPKG_FORCE_SYSTEM_BINARIES” warning

You only need to execute package-vcpkg.sh to complete the compilation of the corresponding platform

How was this patch tested?

in arm platform, you can execute the package-vcpkg.sh like this:
./dev/package-vcpkage.sh

To execute package-vcpkg.sh to compile the dependency libraries in vcpkg.json and vcpkg-tool。
"Environment variable VCPKG_FORCE_SYSTEM_BINARIES must be set on arm, s390x, ppc64le and riscv platforms" is not displayed.

i build it on my local pc(cpu:m1pro ; centos7 docker). i will show the logs :

compare-faile compare-ok

…G_CXX_FLAGS on the arm platform. fixed Environment variable VCPKG_FORCE_SYSTEM_BINARIES[VL][BUILD]
@github-actions github-actions bot added the BUILD label Mar 13, 2025
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@PHILO-HE PHILO-HE changed the title [GLUTEN-<#8981>][VL]Support manual set vcpkg compilation parameter for arm.and fixd Environment variable VCPKG_FORCE_SYSTEM_BINARIES [GLUTEN-8981][VL] Add vcpkg triplet for building Gluten on arm Mar 13, 2025
Copy link

#8981

@zhztheplayer
Copy link
Member

Might need to link this with #7664?

We don't yet have CI jobs for ARM build so perhaps we'd setup one asap to track on related changes.

Velox + ARM build is also not yet verified by Velox community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VL] Need manual set vcpkg compilation parameter for arm palteform like x86 platform
2 participants