-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Smoke tester requiring Python 3.12+ #14556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@stefanvodita whatever version we want to target, we should configure in the python 3.12 is indeed required for the FYI Both python 3.11 and 3.12 are no longer receiving updates except security fixes. Only 3.13 sees bugfixes. |
I see we have 3.12 configured and at least for me that's alright. But do we have a way to warn users of the scripts that they need 3.12? |
I think there is a way, there is even some existing logic to do it (I suspect it has the wrong version set). Additionally, I know existing logic uses an outdated method to check the python version: because I disabled the linter violation around that. I've also a concern that for an old python it may just fail at We should definitely improve here though! |
#14326 added a line in scriptutil that imports
override
fromtyping
, which was introduced in Python 3.12.Running the smoke tester with 3.11, errors out like so:
Maybe we can make it clearer what version Python is required?
The text was updated successfully, but these errors were encountered: