Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

Commit f940d14

Browse files
committed
SUBMARINE-1349. Fix the syntax error reported in sonarcloud and add init value for apiversion in XGboostjobList.java
1 parent f492e42 commit f940d14

File tree

3 files changed

+7
-15
lines changed

3 files changed

+7
-15
lines changed

submarine-server/server-core/src/main/java/org/apache/submarine/server/manager/ModelVersionManager.java

+3-7
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,10 @@ public class ModelVersionManager {
5050
*
5151
* @return object
5252
*/
53-
public static ModelVersionManager getInstance() {
53+
public static synchronized ModelVersionManager getInstance() {
5454
if (manager == null) {
55-
synchronized (ModelVersionManager.class) {
56-
if (manager == null) {
57-
manager = new ModelVersionManager(new ModelVersionService(), new ModelVersionTagService(),
58-
new Client());
59-
}
60-
}
55+
manager = new ModelVersionManager(new ModelVersionService(), new ModelVersionTagService(),
56+
new Client());
6157
}
6258
return manager;
6359
}

submarine-server/server-core/src/main/java/org/apache/submarine/server/manager/RegisteredModelManager.java

+3-7
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,10 @@ public class RegisteredModelManager {
5454
*
5555
* @return object
5656
*/
57-
public static RegisteredModelManager getInstance() {
57+
public static synchronized RegisteredModelManager getInstance() {
5858
if (manager == null) {
59-
synchronized (RegisteredModelManager.class) {
60-
if (manager == null) {
61-
manager = new RegisteredModelManager(new RegisteredModelService(), new ModelVersionService(),
62-
new RegisteredModelTagService(), new Client());
63-
}
64-
}
59+
manager = new RegisteredModelManager(new RegisteredModelService(), new ModelVersionService(),
60+
new RegisteredModelTagService(), new Client());
6561
}
6662
return manager;
6763
}

submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/model/xgboostjob/XGBoostJobList.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
public class XGBoostJobList implements KubernetesListObject {
2929
@SerializedName("apiVersion")
30-
private String apiVersion;
30+
private String apiVersion = XGBoostJob.CRD_XGBOOST_API_VERSION_V1;
3131

3232
@SerializedName("kind")
3333
private String kind;

0 commit comments

Comments
 (0)