Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Y Axis Title Margin of 15 often overlaps with axis value text #32528

Open
sfirke opened this issue Mar 6, 2025 · 4 comments
Open

Default Y Axis Title Margin of 15 often overlaps with axis value text #32528

sfirke opened this issue Mar 6, 2025 · 4 comments
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed good first issue Good first issues for new contributors need:design-review Requires input/approval from a Designer

Comments

@sfirke
Copy link
Member

sfirke commented Mar 6, 2025

Screenshot

Image

Description

The default Y Axis Title Margin value is 15. A common first step for users is to increase it to 45 so that it stands far enough away from the Y Axis. I polled Slack users about this and others concurred.

Design input

Default value should be something like 45.

@sfirke sfirke added the need:design-review Requires input/approval from a Designer label Mar 6, 2025
@dosubot dosubot bot added the #bug:cosmetic Cosmetic/layout/design tweak needed label Mar 6, 2025
@sfirke
Copy link
Member Author

sfirke commented Mar 6, 2025

I wonder if we just change this value?

to default: TITLE_MARGIN_OPTIONS[1], instead of [0] to make it 30?

@rusackas
Copy link
Member

rusackas commented Mar 6, 2025

Sounds reasonable to me! Simple PR to boot! No migrations required, and I wouldn't constitute it a breaking change.

@rusackas rusackas added the review:checkpoint Last PR reviewed during the daily review standup label Mar 6, 2025
@rea725
Copy link

rea725 commented Mar 6, 2025

Image

@sfirke sfirke added the good first issue Good first issues for new contributors label Mar 6, 2025
@mistercrunch
Copy link
Member

I wish echarts was more responsive here, or maybe we're not using it right (?) Anyhow bumping the default seems like a good place to start.

@rusackas rusackas removed the review:checkpoint Last PR reviewed during the daily review standup label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed good first issue Good first issues for new contributors need:design-review Requires input/approval from a Designer
Projects
None yet
Development

No branches or pull requests

4 participants