-
Notifications
You must be signed in to change notification settings - Fork 4
preproccessor cuts off the last line of a source breaking WebPack #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@artificialtrends are you still maintaining this repo? |
Yes I am. Looking into your issue now |
I will checkout your sample project and see what I can find...keep you posted no worries |
should have answer by tomorrow. |
Yes On Tue, Feb 23, 2016 at 9:13 AM, Benny Bottema notifications@github.com
|
@artificialtrends any update? It's a little annoying that when I forget an extra linefeed at the end that I get the vague "X is not a module." error |
I am working on it...will have a fix by tomorrow. On Mon, Feb 29, 2016 at 8:30 AM, Benny Bottema notifications@github.com
|
@artificialtrends, @PragJared. I'm sorry, but you need to work on your expectancy management skills. 7 days after question:
4 Days later:
14 days later: nothing. Look it's ok if you can't handle the work load, but don't tell me you have an answer and a solution the next day. Do I need to fork this and fix it myself? I'll keep you posted, no worries |
... |
@bbottema Check the pull request. I think it will solve your issue. |
@ohjimijimijimi, I moved on, sorry. angular/angular2-seed works better anyway. |
hi, any updates? is either of the PR going to be merged? @PragJared are you maintaining this repo? |
I'm running .ts files through ts-loader, but the preprocessor (v1.0.5) seems to break the process, even when returning the source directly.
I noticed that the last line was missing, which contains the export = statement. So it seems preprocessor cuts off the last line (I'm using a file source callback).
Without preprocessor it produces a working bundle.js, but with it I get the following error:
I noticed that in the preprocessor the last line was missing which in my case contains the export = statement. It's solved when I add an extra empty line at the end of the file.
I made a sample project on GitHub. If you remove the empty lines at the end of ClassA.ts or ClassB.ts the build stops working.
The text was updated successfully, but these errors were encountered: