Skip to content

[Helix] Cors.FunctionalTest needs additional files to run on helix #7990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HaoK opened this issue Feb 27, 2019 · 4 comments
Closed

[Helix] Cors.FunctionalTest needs additional files to run on helix #7990

HaoK opened this issue Feb 27, 2019 · 4 comments
Assignees
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-helix Required to enable Helix task
Milestone

Comments

@HaoK
Copy link
Member

HaoK commented Feb 27, 2019

This test needs more than just the sample destination/origin files it appears to run. Whatever files it needs should be included in the publish directory for it to be running via dotnet vstest to work on helix.

The following changes will copy over the samples to the publish directory and find the files, but there were runtime errors related to npm after that

    <Compile Include="$(SharedSourceRoot)test\SkipOnHelixAttribute.cs" />
    <HelixContent Include="..\..\samples\SampleOrigin\**\*.*" LinkBase="SampleOrigin" />
    <HelixContent Include="..\..\samples\SampleDestination\**\*.*" LinkBase="SampleDestination" />

  // Inside of CorsMiddlewareFunctionalTest.CreateDeployments
            var samplesPath = SkipOnHelixAttribute.OnHelix() ? AppContext.BaseDirectory : Path.Combine(TestPathUtilities.GetSolutionRootDirectory("Middleware"), "CORS", "samples"); 
@HaoK
Copy link
Member Author

HaoK commented Feb 27, 2019

Files such as project.json will likely need to be published as well

@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 3, 2019
@danroth27 danroth27 added the task label Apr 3, 2019
@danroth27 danroth27 added this to the 3.0.0-preview5 milestone Apr 3, 2019
@mkArtakMSFT
Copy link
Contributor

@HaoK what's the status of this? Seems like this hasn't been updated for a while.
I'm moving this to preview6, but if you have a PR ready to go - feel free to merge it and bring this back.

@mkArtakMSFT mkArtakMSFT added 1 - Ready feature-helix Required to enable Helix labels Apr 22, 2019
@natemcmaster
Copy link
Contributor

Looks like this test project is one of many which require refactoring to work on Helix. cref #10268

@HaoK
Copy link
Member Author

HaoK commented Sep 16, 2019

Closing since these tests were removed via #13826

@HaoK HaoK closed this as completed Sep 16, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-helix Required to enable Helix task
Projects
None yet
Development

No branches or pull requests

5 participants