Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8-annoations argument called respect-type-ignore #16630

Open
martinResearch opened this issue Mar 11, 2025 · 1 comment
Open

Add flake8-annoations argument called respect-type-ignore #16630

martinResearch opened this issue Mar 11, 2025 · 1 comment
Labels
suppression Related to supression of violations e.g. noqa

Comments

@martinResearch
Copy link

Summary

flake8-annotations supports an options --respect-type-ignore. See here.
It would be great to have support for it in Ruff.

@dylwil3 dylwil3 added configuration Related to settings and configuration suppression Related to supression of violations e.g. noqa labels Mar 11, 2025
@MichaReiser MichaReiser removed the configuration Related to settings and configuration label Mar 12, 2025
@MichaReiser
Copy link
Member

I don't think we want to support rule-specific suppression comments. That would become rather confusing, especially once we remove the linter groups as they exist today (#1774).

Our in-work type checker will support type: ignore comments and it's somewhat likely that we'll support it as well in Ruff once we transition Ruff to use the same infrastructure but with an option to ignore type: ignore suppression comments.

However, I could also see us to disallow the use of type: ignore for lint like rules. That's why I think we should wait with adding support for type: ignore until we have a better understanding where we'll go with the Ruff/Red Knot integration

Related: #1203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suppression Related to supression of violations e.g. noqa
Projects
None yet
Development

No branches or pull requests

3 participants