False positives for quoted-type-alias (TC008)

[ntBre]

Recursive type definition from ibis:

if sys.version_info >= (3, 10):
    from types import UnionType
    from typing import TypeAlias

    # Keep this alias in sync with unittest.case._ClassInfo
    _ClassInfo: TypeAlias = type | UnionType | tuple["_ClassInfo", ...]
else:
    from typing_extensions import TypeAlias

    UnionType = object()
    _ClassInfo: TypeAlias = Union[type, tuple["_ClassInfo", ...]]  # TC008

Conditional import from zulip:

if settings.ZILENCER_ENABLED:
    from zilencer.models import RemoteInstallationCount, RemoteRealmCount, RemoteZulipServer

...

TableType: TypeAlias = (
        type["RemoteInstallationCount"]  # TC008
        | type[InstallationCount]
        | type["RemoteRealmCount"]
        | type[RealmCount]

These all look like false positives except the latchbio cases.

The Zulip cases require an import that is conditional on some settings type other than TYPE_CHECKING, so I think unconditionally unquoting those could be a problem.

And the ibis case is a recursive type alias, which I think must be quoted? Possibly the rule doesn't descend into the Union because it handles the ... | ... version fine.

Originally posted by @ntBre in #16639 (comment)

See this ecosystem check for what "these" refers to and this comment for additional context and possible solutions.