Skip to content

[Doc Bug] Incorrect path for DCP_TARBALL_TO_INGEST in f2/hdk/README.md #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jinhyeok0410 opened this issue Apr 21, 2025 · 3 comments
Closed

Comments

@jinhyeok0410
Copy link

I’d like to report a small issue I found while testing Step 6 in the following README:
https://github.com/aws/aws-fpga/blob/f2/hdk/README.md

The current line:
export DCP_TARBALL_TO_INGEST='<$CL_DIR/build/checkpoints/to_aws/YYYY_MM_DD-HHMMSS.Developer_CL.tar>'
doesn’t seem to reflect the actual path on the FPGA Development AMI (Ubuntu).

Based on my test, the to_aws directory is not present, so the correct path should be:
export DCP_TARBALL_TO_INGEST='<$CL_DIR/build/checkpoints/YYYY_MM_DD-HHMMSS.Developer_CL.tar>'
Hope this helps improve the setup experience for other users!

@czfpga
Copy link
Contributor

czfpga commented Apr 21, 2025

Hi @jinhyeok0410,

Thanks for reporting this issue. The team will fix this in the next release.

@DavidLiuAmzn
Copy link

Hi @jinhyeok0410. Echoing my teammate's sentiment for reporting the issue. If you'd like, please feel free to open a Pull Request with the fix, so that you can take some credit for the change. Otherwise, we will fix the issue in a future release.

@mjthimm
Copy link
Contributor

mjthimm commented Apr 24, 2025

Hi @jinhyeok0410,

This fix has been incorporated into the next release!

Please see the release notes to credit you for this fix!

Best,
Max

@mjthimm mjthimm closed this as completed Apr 24, 2025
@mjthimm mjthimm mentioned this issue Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants