Skip to content

[BUG] Auth Mode Configuration Parameter lost after updating using a magic #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bechbd opened this issue Mar 7, 2023 · 1 comment
Closed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bechbd
Copy link
Contributor

bechbd commented Mar 7, 2023

Describe the bug
When updating the graph notebook config using the %%graph_notebook_config or %%graph_notebook_host magics, lose the authorization parameter auth_mode in the configuration.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new notebook and verify that the auth_mode parameter exists
  2. Update the configuration using the magics
  3. Check the configuration and the auth_mode parameter does not exist
@bechbd bechbd added the bug Something isn't working label Mar 7, 2023
@bechbd bechbd changed the title [BUG] Summarize the issue in a few words here [BUG] Auth Mode Configuration Parameter lost after updating using a magic Mar 7, 2023
@bechbd
Copy link
Contributor Author

bechbd commented Mar 7, 2023

Upon further investigation, this was root caused to using a host not in the allowlist configuration, so it was only saving the relevant parameters.

My request here is to make it more explicit that only part of the configuration has been saved due to unneeded parameters in the request. Something like

The provided configuration contains parameters that are not required for the selected configuration.  These parameters have not been saved. 

Bonus points if we can list out the parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Resolved
Development

No branches or pull requests

2 participants