Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Confirm all modules are available to run in AWS-CN partition #193

Open
dgraeber opened this issue Jul 17, 2024 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@dgraeber
Copy link

Remove all hardcoded references to the :aws: partition.

Typically they would be referenced in the modulestack.yaml and stack.py (if python based). No need to modify unittests.

Some examples of modules that need to be refacotred:

  • modules/eks/ray-on-eks
  • modules/examples/airflow-dags
  • modules/sagemaker/sagemaker-model-cicd (??? - Not sure about this)
  • modules/sagemaker/sagemaker-service-templates-service-catalog
@dgraeber dgraeber added the enhancement New feature or request label Jul 17, 2024
@clokep
Copy link
Contributor

clokep commented Aug 16, 2024

#222 partially handled this, the following modules should now work in other partitions:

  • fmops/sagemaker-jumpstart-fm-endpoint
  • sagemaker/sagemaker-endpoint
  • sagemaker/sagemaker-notebook
  • sagemaker/sagemaker-studio

The following are missing services (and can't be supported):

  • fmops/bedrock-finetuning
  • sagemaker/sagemaker-model-monitoring
  • sagemaker/sagemaker-model-package-group

The rest need a bit more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants