Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial loading of skf #22

Closed
johnlees opened this issue Feb 21, 2023 · 2 comments
Closed

Partial loading of skf #22

johnlees opened this issue Feb 21, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request not planned This will not be worked on

Comments

@johnlees
Copy link
Member

If the skf is very large, loading and decompressing the whole thing is slow. It might be possible just to define and get a header struct, which would be useful for ska nk.

@johnlees johnlees added the enhancement New feature or request label Feb 21, 2023
@johnlees johnlees self-assigned this Feb 21, 2023
@johnlees
Copy link
Member Author

Could try #[serde(skip_deserializing)] on variants fields

@johnlees johnlees added the not planned This will not be worked on label Jul 11, 2023
@johnlees
Copy link
Member Author

Tried skip_deserialising trait, and making a smaller struct which omits the large fields. Both take just as long to read in. It's possible this is due to either the CBOR format used (I think more likely) or the compression, but either way this would require a breaking change to the .skf format to work. I've got a couple of thoughts about that, but I will track them in #17 instead.

@johnlees johnlees closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request not planned This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant