Skip to content

Commit 4c48760

Browse files
KarlK90KarlK90
authored
Apply EXPECT_REPORT and EXPECT_EMPTY_REPORT (#17311)
...convenience macros to test cases that where missed during #17284
1 parent 95d20e6 commit 4c48760

File tree

9 files changed

+76
-76
lines changed

9 files changed

+76
-76
lines changed

‎tests/tap_hold_configurations/default_mod_tap/test_tap_hold.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ TEST_F(DefaultTapHold, tap_regular_key_while_layer_tap_key_is_held) {
133133
EXPECT_REPORT(driver, (KC_P));
134134
EXPECT_REPORT(driver, (KC_P, KC_A));
135135
EXPECT_REPORT(driver, (KC_P));
136-
EXPECT_CALL(driver, send_keyboard_mock(_));
136+
EXPECT_EMPTY_REPORT(driver);
137137
layer_tap_hold_key.release();
138138
run_one_scan_loop();
139139
testing::Mock::VerifyAndClearExpectations(&driver);

‎tests/tap_hold_configurations/ignore_mod_tap_interrupt/test_tap_hold.cpp

+12-12
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,10 @@ TEST_F(IgnoreModTapInterrupt, tap_regular_key_while_mod_tap_key_is_held) {
5353
testing::Mock::VerifyAndClearExpectations(&driver);
5454

5555
/* Release mod-tap-hold key */
56-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
57-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_A, KC_P)));
58-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
59-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
56+
EXPECT_REPORT(driver, (KC_P));
57+
EXPECT_REPORT(driver, (KC_A, KC_P));
58+
EXPECT_REPORT(driver, (KC_P));
59+
EXPECT_EMPTY_REPORT(driver);
6060
mod_tap_hold_key.release();
6161
run_one_scan_loop();
6262
testing::Mock::VerifyAndClearExpectations(&driver);
@@ -89,10 +89,10 @@ TEST_F(IgnoreModTapInterrupt, tap_mod_tap_key_while_mod_tap_key_is_held) {
8989
testing::Mock::VerifyAndClearExpectations(&driver);
9090

9191
/* Release first mod-tap-hold key */
92-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
93-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_A, KC_P)));
94-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
95-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
92+
EXPECT_REPORT(driver, (KC_P));
93+
EXPECT_REPORT(driver, (KC_A, KC_P));
94+
EXPECT_REPORT(driver, (KC_P));
95+
EXPECT_EMPTY_REPORT(driver);
9696
first_mod_tap_hold_key.release();
9797
run_one_scan_loop();
9898
testing::Mock::VerifyAndClearExpectations(&driver);
@@ -126,10 +126,10 @@ TEST_F(IgnoreModTapInterrupt, tap_regular_key_while_layer_tap_key_is_held) {
126126
testing::Mock::VerifyAndClearExpectations(&driver);
127127

128128
/* Release layer-tap-hold key */
129-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
130-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P, regular_key.report_code)));
131-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
132-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
129+
EXPECT_REPORT(driver, (KC_P));
130+
EXPECT_REPORT(driver, (KC_P, regular_key.report_code));
131+
EXPECT_REPORT(driver, (KC_P));
132+
EXPECT_EMPTY_REPORT(driver);
133133
layer_tap_hold_key.release();
134134
run_one_scan_loop();
135135
testing::Mock::VerifyAndClearExpectations(&driver);

‎tests/tap_hold_configurations/permissive_hold/test_one_shot_keys.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,14 @@ TEST_P(OneShotParametrizedTestFixture, OSMAsRegularModifierWithAdditionalKeypres
4444
testing::Mock::VerifyAndClearExpectations(&driver);
4545

4646
/* Release regular key */
47-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(osm_key.report_code))).Times(2);
48-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(regular_key.report_code, osm_key.report_code))).Times(1);
47+
EXPECT_REPORT(driver, (osm_key.report_code)).Times(2);
48+
EXPECT_REPORT(driver, (regular_key.report_code, osm_key.report_code)).Times(1);
4949
regular_key.release();
5050
run_one_scan_loop();
5151
testing::Mock::VerifyAndClearExpectations(&driver);
5252

5353
/* Release OSM */
54-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport())).Times(1);
54+
EXPECT_EMPTY_REPORT(driver).Times(1);
5555
osm_key.release();
5656
run_one_scan_loop();
5757
testing::Mock::VerifyAndClearExpectations(&driver);

‎tests/tap_hold_configurations/permissive_hold/test_tap_hold.cpp

+10-10
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,15 @@ TEST_F(PermissiveHold, tap_regular_key_while_mod_tap_key_is_held) {
4646
testing::Mock::VerifyAndClearExpectations(&driver);
4747

4848
/* Release regular key */
49-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSHIFT)));
50-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSHIFT, regular_key.report_code)));
51-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSHIFT)));
49+
EXPECT_REPORT(driver, (KC_LSHIFT));
50+
EXPECT_REPORT(driver, (KC_LSHIFT, regular_key.report_code));
51+
EXPECT_REPORT(driver, (KC_LSHIFT));
5252
regular_key.release();
5353
run_one_scan_loop();
5454
testing::Mock::VerifyAndClearExpectations(&driver);
5555

5656
/* Release mod-tap-hold key */
57-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
57+
EXPECT_EMPTY_REPORT(driver);
5858
mod_tap_hold_key.release();
5959
run_one_scan_loop();
6060
testing::Mock::VerifyAndClearExpectations(&driver);
@@ -81,15 +81,15 @@ TEST_F(PermissiveHold, tap_mod_tap_key_while_mod_tap_key_is_held) {
8181
testing::Mock::VerifyAndClearExpectations(&driver);
8282

8383
/* Release second mod-tap-hold key */
84-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSHIFT)));
85-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSHIFT, second_mod_tap_hold_key.report_code)));
86-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSHIFT)));
84+
EXPECT_REPORT(driver, (KC_LSHIFT));
85+
EXPECT_REPORT(driver, (KC_LSHIFT, second_mod_tap_hold_key.report_code));
86+
EXPECT_REPORT(driver, (KC_LSHIFT));
8787
second_mod_tap_hold_key.release();
8888
run_one_scan_loop();
8989
testing::Mock::VerifyAndClearExpectations(&driver);
9090

9191
/* Release first mod-tap-hold key */
92-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
92+
EXPECT_EMPTY_REPORT(driver);
9393
first_mod_tap_hold_key.release();
9494
run_one_scan_loop();
9595
testing::Mock::VerifyAndClearExpectations(&driver);
@@ -117,8 +117,8 @@ TEST_F(PermissiveHold, tap_regular_key_while_layer_tap_key_is_held) {
117117
testing::Mock::VerifyAndClearExpectations(&driver);
118118

119119
/* Release regular key */
120-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(layer_key.report_code)));
121-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
120+
EXPECT_REPORT(driver, (layer_key.report_code));
121+
EXPECT_EMPTY_REPORT(driver);
122122
regular_key.release();
123123
run_one_scan_loop();
124124
testing::Mock::VerifyAndClearExpectations(&driver);

‎tests/tap_hold_configurations/permissive_hold_ignore_mod_tap_interrupt/test_tap_hold.cpp

+10-10
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,15 @@ TEST_F(PermissiveHold_IgnoreModTapInterrupt, tap_regular_key_while_mod_tap_key_i
4848
testing::Mock::VerifyAndClearExpectations(&driver);
4949

5050
/* Release regular key */
51-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT)));
52-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT, KC_A)));
53-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT)));
51+
EXPECT_REPORT(driver, (KC_LSFT));
52+
EXPECT_REPORT(driver, (KC_LSFT, KC_A));
53+
EXPECT_REPORT(driver, (KC_LSFT));
5454
regular_key.release();
5555
run_one_scan_loop();
5656
testing::Mock::VerifyAndClearExpectations(&driver);
5757

5858
/* Release mod-tap-hold key */
59-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
59+
EXPECT_EMPTY_REPORT(driver);
6060
mod_tap_hold_key.release();
6161
run_one_scan_loop();
6262
testing::Mock::VerifyAndClearExpectations(&driver);
@@ -83,15 +83,15 @@ TEST_F(PermissiveHold_IgnoreModTapInterrupt, tap_mod_tap_key_while_mod_tap_key_i
8383
testing::Mock::VerifyAndClearExpectations(&driver);
8484

8585
/* Release second tap-hold key */
86-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT)));
87-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT, KC_A)));
88-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT)));
86+
EXPECT_REPORT(driver, (KC_LSFT));
87+
EXPECT_REPORT(driver, (KC_LSFT, KC_A));
88+
EXPECT_REPORT(driver, (KC_LSFT));
8989
second_mod_tap_hold_key.release();
9090
run_one_scan_loop();
9191
testing::Mock::VerifyAndClearExpectations(&driver);
9292

9393
/* Release first mod-tap-hold key */
94-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
94+
EXPECT_EMPTY_REPORT(driver);
9595
first_mod_tap_hold_key.release();
9696
run_one_scan_loop();
9797
testing::Mock::VerifyAndClearExpectations(&driver);
@@ -119,8 +119,8 @@ TEST_F(PermissiveHold_IgnoreModTapInterrupt, tap_regular_key_while_layer_tap_key
119119
testing::Mock::VerifyAndClearExpectations(&driver);
120120

121121
/* Release regular key */
122-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_B)));
123-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
122+
EXPECT_REPORT(driver, (KC_B));
123+
EXPECT_EMPTY_REPORT(driver);
124124
regular_key.release();
125125
run_one_scan_loop();
126126
testing::Mock::VerifyAndClearExpectations(&driver);

‎tests/tap_hold_configurations/retro_tapping/test_tap_hold.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ TEST_F(RetroTapping, tap_and_hold_mod_tap_hold_key) {
4242

4343
/* Release mod-tap-hold key. */
4444
/* TODO: Why is LSHIFT send at all? */
45-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSHIFT)));
46-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
47-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
48-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
45+
EXPECT_REPORT(driver, (KC_LSHIFT));
46+
EXPECT_EMPTY_REPORT(driver);
47+
EXPECT_REPORT(driver, (KC_P));
48+
EXPECT_EMPTY_REPORT(driver);
4949
mod_tap_hold_key.release();
5050
run_one_scan_loop();
5151
testing::Mock::VerifyAndClearExpectations(&driver);

‎tests/tap_hold_configurations/retro_tapping/test_tapping.cpp

+14-14
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ TEST_F(Tapping, HoldA_SHFT_T_KeyReportsShift) {
3737
idle_for(TAPPING_TERM);
3838
testing::Mock::VerifyAndClearExpectations(&driver);
3939

40-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT)));
40+
EXPECT_REPORT(driver, (KC_LSFT));
4141
run_one_scan_loop();
4242
testing::Mock::VerifyAndClearExpectations(&driver);
4343

44-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
45-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
46-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
44+
EXPECT_EMPTY_REPORT(driver);
45+
EXPECT_REPORT(driver, (KC_P));
46+
EXPECT_EMPTY_REPORT(driver);
4747
mod_tap_hold_key.release();
4848
run_one_scan_loop();
4949
testing::Mock::VerifyAndClearExpectations(&driver);
@@ -63,20 +63,20 @@ TEST_F(Tapping, ANewTapWithinTappingTermIsBuggy) {
6363
testing::Mock::VerifyAndClearExpectations(&driver);
6464

6565
/* Release mod_tap_hold key */
66-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
67-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
66+
EXPECT_REPORT(driver, (KC_P));
67+
EXPECT_EMPTY_REPORT(driver);
6868
key_shift_hold_p_tap.release();
6969
run_one_scan_loop();
7070
testing::Mock::VerifyAndClearExpectations(&driver);
7171

7272
/* Press mod_tap_hold key again */
73-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
73+
EXPECT_REPORT(driver, (KC_P));
7474
key_shift_hold_p_tap.press();
7575
run_one_scan_loop();
7676
testing::Mock::VerifyAndClearExpectations(&driver);
7777

7878
/* Release mod_tap_hold key again */
79-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
79+
EXPECT_EMPTY_REPORT(driver);
8080
key_shift_hold_p_tap.release();
8181
idle_for(TAPPING_TERM + 1);
8282
testing::Mock::VerifyAndClearExpectations(&driver);
@@ -88,8 +88,8 @@ TEST_F(Tapping, ANewTapWithinTappingTermIsBuggy) {
8888
testing::Mock::VerifyAndClearExpectations(&driver);
8989

9090
/* Release mod_tap_hold key again */
91-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
92-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
91+
EXPECT_REPORT(driver, (KC_P));
92+
EXPECT_EMPTY_REPORT(driver);
9393
key_shift_hold_p_tap.release();
9494
idle_for(TAPPING_TERM + 1);
9595
testing::Mock::VerifyAndClearExpectations(&driver);
@@ -102,10 +102,10 @@ TEST_F(Tapping, ANewTapWithinTappingTermIsBuggy) {
102102

103103
/* Release mod_tap_hold key again */
104104
/* TODO: Why is KC_LSFT send? */
105-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT)));
106-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
107-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
108-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
105+
EXPECT_REPORT(driver, (KC_LSFT));
106+
EXPECT_EMPTY_REPORT(driver);
107+
EXPECT_REPORT(driver, (KC_P));
108+
EXPECT_EMPTY_REPORT(driver);
109109
key_shift_hold_p_tap.release();
110110
run_one_scan_loop();
111111
testing::Mock::VerifyAndClearExpectations(&driver);

‎tests/tap_hold_configurations/tapping_force_hold/test_action_layer.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,13 @@ TEST_F(ActionLayer, LayerTapToggleWithToggleWithKeypress) {
6666

6767
testing::Mock::VerifyAndClearExpectations(&driver);
6868

69-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_A))).Times(1);
69+
EXPECT_REPORT(driver, (KC_A)).Times(1);
7070
regular_key.press();
7171
run_one_scan_loop();
7272
expect_layer_state(0);
7373
testing::Mock::VerifyAndClearExpectations(&driver);
7474

75-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport())).Times(1);
75+
EXPECT_EMPTY_REPORT(driver).Times(1);
7676
regular_key.release();
7777
run_one_scan_loop();
7878
expect_layer_state(0);

‎tests/tap_hold_configurations/tapping_force_hold/test_tap_hold.cpp

+20-20
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,15 @@ TEST_F(TappingForceHold, tap_regular_key_while_mod_tap_key_is_held) {
5454
testing::Mock::VerifyAndClearExpectations(&driver);
5555

5656
/* Release mod-tap-hold key. */
57-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT)));
57+
EXPECT_REPORT(driver, (KC_LSFT));
5858
mod_tap_hold_key.release();
5959
run_one_scan_loop();
6060
testing::Mock::VerifyAndClearExpectations(&driver);
6161

6262
/* Idle for tapping term of mod tap hold key. */
63-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT, KC_A)));
64-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT)));
65-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
63+
EXPECT_REPORT(driver, (KC_LSFT, KC_A));
64+
EXPECT_REPORT(driver, (KC_LSFT));
65+
EXPECT_EMPTY_REPORT(driver);
6666
idle_for(TAPPING_TERM - 3);
6767
testing::Mock::VerifyAndClearExpectations(&driver);
6868
}
@@ -94,15 +94,15 @@ TEST_F(TappingForceHold, tap_mod_tap_key_while_mod_tap_key_is_held) {
9494
testing::Mock::VerifyAndClearExpectations(&driver);
9595

9696
/* Release first mod-tap-hold key */
97-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT)));
97+
EXPECT_REPORT(driver, (KC_LSFT));
9898
first_mod_tap_hold_key.release();
9999
run_one_scan_loop();
100100
testing::Mock::VerifyAndClearExpectations(&driver);
101101

102102
/* Idle for tapping term of first mod tap hold key. */
103-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT, KC_A)));
104-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT)));
105-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
103+
EXPECT_REPORT(driver, (KC_LSFT, KC_A));
104+
EXPECT_REPORT(driver, (KC_LSFT));
105+
EXPECT_EMPTY_REPORT(driver);
106106
idle_for(TAPPING_TERM - 3);
107107
testing::Mock::VerifyAndClearExpectations(&driver);
108108
}
@@ -135,10 +135,10 @@ TEST_F(TappingForceHold, tap_regular_key_while_layer_tap_key_is_held) {
135135
testing::Mock::VerifyAndClearExpectations(&driver);
136136

137137
/* Release layer-tap-hold key */
138-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
139-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_A, KC_P)));
140-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
141-
EXPECT_CALL(driver, send_keyboard_mock(_));
138+
EXPECT_REPORT(driver, (KC_P));
139+
EXPECT_REPORT(driver, (KC_A, KC_P));
140+
EXPECT_REPORT(driver, (KC_P));
141+
EXPECT_EMPTY_REPORT(driver);
142142
layer_tap_hold_key.release();
143143
run_one_scan_loop();
144144
testing::Mock::VerifyAndClearExpectations(&driver);
@@ -158,8 +158,8 @@ TEST_F(TappingForceHold, tap_mod_tap_hold_key_two_times) {
158158
testing::Mock::VerifyAndClearExpectations(&driver);
159159

160160
/* Release mod-tap-hold key. */
161-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
162-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
161+
EXPECT_REPORT(driver, (KC_P));
162+
EXPECT_EMPTY_REPORT(driver);
163163
mod_tap_hold_key.release();
164164
run_one_scan_loop();
165165
testing::Mock::VerifyAndClearExpectations(&driver);
@@ -171,8 +171,8 @@ TEST_F(TappingForceHold, tap_mod_tap_hold_key_two_times) {
171171
testing::Mock::VerifyAndClearExpectations(&driver);
172172

173173
/* Release mod-tap-hold key. */
174-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
175-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
174+
EXPECT_REPORT(driver, (KC_P));
175+
EXPECT_EMPTY_REPORT(driver);
176176
mod_tap_hold_key.release();
177177
run_one_scan_loop();
178178
testing::Mock::VerifyAndClearExpectations(&driver);
@@ -192,8 +192,8 @@ TEST_F(TappingForceHold, tap_mod_tap_hold_key_twice_and_hold_on_second_time) {
192192
testing::Mock::VerifyAndClearExpectations(&driver);
193193

194194
/* Release mod-tap-hold key. */
195-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
196-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
195+
EXPECT_REPORT(driver, (KC_P));
196+
EXPECT_EMPTY_REPORT(driver);
197197
mod_tap_hold_key.release();
198198
run_one_scan_loop();
199199
testing::Mock::VerifyAndClearExpectations(&driver);
@@ -205,8 +205,8 @@ TEST_F(TappingForceHold, tap_mod_tap_hold_key_twice_and_hold_on_second_time) {
205205
testing::Mock::VerifyAndClearExpectations(&driver);
206206

207207
/* Release mod-tap-hold key. */
208-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSHIFT)));
209-
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
208+
EXPECT_REPORT(driver, (KC_LSHIFT));
209+
EXPECT_EMPTY_REPORT(driver);
210210
mod_tap_hold_key.release();
211211
run_one_scan_loop();
212212
testing::Mock::VerifyAndClearExpectations(&driver);

0 commit comments

Comments
 (0)