Skip to content

Commit f7e7671

Browse files
authored
Migrate more makefile utilities to builddefs sub-directory (#16002)
1 parent 7a0fd64 commit f7e7671

12 files changed

+15
-13
lines changed

Makefile

+3-3
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ define PARSE_KEYMAP
275275
# Specify the variables that we are passing forward to submake
276276
MAKE_VARS := KEYBOARD=$$(CURRENT_KB) KEYMAP=$$(CURRENT_KM) REQUIRE_PLATFORM_KEY=$$(REQUIRE_PLATFORM_KEY) QMK_BIN=$$(QMK_BIN)
277277
# And the first part of the make command
278-
MAKE_CMD := $$(MAKE) -r -R -C $(ROOT_DIR) -f build_keyboard.mk $$(MAKE_TARGET)
278+
MAKE_CMD := $$(MAKE) -r -R -C $(ROOT_DIR) -f $(BUILDDEFS_PATH)/build_keyboard.mk $$(MAKE_TARGET)
279279
# The message to display
280280
MAKE_MSG := $$(MSG_MAKE_KB)
281281
# We run the command differently, depending on if we want more output or not
@@ -317,7 +317,7 @@ define BUILD_TEST
317317
TEST_NAME := $$(notdir $$(TEST_PATH))
318318
MAKE_TARGET := $2
319319
COMMAND := $1
320-
MAKE_CMD := $$(MAKE) -r -R -C $(ROOT_DIR) -f build_test.mk $$(MAKE_TARGET)
320+
MAKE_CMD := $$(MAKE) -r -R -C $(ROOT_DIR) -f $(BUILDDEFS_PATH)/build_test.mk $$(MAKE_TARGET)
321321
MAKE_VARS := TEST=$$(TEST_NAME) TEST_PATH=$$(TEST_PATH) FULL_TESTS="$$(FULL_TESTS)"
322322
MAKE_MSG := $$(MSG_MAKE_TEST)
323323
$$(eval $$(call BUILD))
@@ -339,7 +339,7 @@ define PARSE_TEST
339339
TESTS :=
340340
TEST_NAME := $$(firstword $$(subst :, ,$$(RULE)))
341341
TEST_TARGET := $$(subst $$(TEST_NAME),,$$(subst $$(TEST_NAME):,,$$(RULE)))
342-
include $(ROOT_DIR)/testlist.mk
342+
include $(BUILDDEFS_PATH)/testlist.mk
343343
ifeq ($$(TEST_NAME),all)
344344
MATCHED_TESTS := $$(TEST_LIST)
345345
else
File renamed without changes.
File renamed without changes.

build_keyboard.mk builddefs/build_keyboard.mk

+4-4
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ INFO_RULES_MK = $(shell $(QMK_BIN) generate-rules-mk --quiet --escape --keyboard
111111
include $(INFO_RULES_MK)
112112

113113
# Check for keymap.json first, so we can regenerate keymap.c
114-
include build_json.mk
114+
include $(BUILDDEFS_PATH)/build_json.mk
115115

116116
# Pull in keymap level rules.mk
117117
ifeq ("$(wildcard $(KEYMAP_PATH))", "")
@@ -138,7 +138,7 @@ ifeq ("$(wildcard $(KEYMAP_PATH))", "")
138138
KEYMAP_PATH := $(MAIN_KEYMAP_PATH_1)
139139
else ifneq ($(LAYOUTS),)
140140
# If we haven't found a keymap yet fall back to community layouts
141-
include build_layout.mk
141+
include $(BUILDDEFS_PATH)/build_layout.mk
142142
else
143143
$(call CATASTROPHIC_ERROR,Invalid keymap,Could not find keymap)
144144
# this state should never be reached
@@ -398,7 +398,7 @@ VPATH += $(COMMON_VPATH)
398398
VPATH += $(KEYBOARD_OUTPUT)/src
399399
VPATH += $(KEYMAP_OUTPUT)/src
400400

401-
include common_features.mk
401+
include $(BUILDDEFS_PATH)/common_features.mk
402402
include $(BUILDDEFS_PATH)/generic_features.mk
403403
include $(TMK_PATH)/protocol.mk
404404
include $(PLATFORM_PATH)/common.mk
@@ -460,7 +460,7 @@ check-md5: build
460460
objs-size: build
461461

462462
include $(BUILDDEFS_PATH)/show_options.mk
463-
include $(TMK_PATH)/rules.mk
463+
include $(BUILDDEFS_PATH)/common_rules.mk
464464

465465
# Ensure we have generated files available for each of the objects
466466
define GEN_FILES
File renamed without changes.

build_test.mk builddefs/build_test.mk

+3-3
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ include tests/test_common/build.mk
5454
include $(TEST_PATH)/test.mk
5555
endif
5656

57-
include common_features.mk
57+
include $(BUILDDEFS_PATH)/common_features.mk
5858
include $(BUILDDEFS_PATH)/generic_features.mk
5959
include $(PLATFORM_PATH)/common.mk
6060
include $(TMK_PATH)/protocol.mk
@@ -63,7 +63,7 @@ include $(QUANTUM_PATH)/encoder/tests/rules.mk
6363
include $(QUANTUM_PATH)/sequencer/tests/rules.mk
6464
include $(PLATFORM_PATH)/test/rules.mk
6565
ifneq ($(filter $(FULL_TESTS),$(TEST)),)
66-
include build_full_test.mk
66+
include $(BUILDDEFS_PATH)/build_full_test.mk
6767
endif
6868

6969
$(TEST)_SRC += \
@@ -77,7 +77,7 @@ $(TEST_OBJ)/$(TEST)_DEFS := $($(TEST)_DEFS)
7777
$(TEST_OBJ)/$(TEST)_CONFIG := $($(TEST)_CONFIG)
7878

7979
include $(PLATFORM_PATH)/$(PLATFORM_KEY)/platform.mk
80-
include $(TMK_PATH)/rules.mk
80+
include $(BUILDDEFS_PATH)/common_rules.mk
8181

8282

8383
$(shell mkdir -p $(BUILD_DIR)/test 2>/dev/null)
File renamed without changes.
File renamed without changes.

testlist.mk builddefs/testlist.mk

File renamed without changes.

lib/python/qmk/cli/multibuild.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def multibuild(cli):
6969
all: {keyboard_safe}_binary
7070
{keyboard_safe}_binary:
7171
@rm -f "{QMK_FIRMWARE}/.build/failed.log.{keyboard_safe}" || true
72-
+@$(MAKE) -C "{QMK_FIRMWARE}" -f "{QMK_FIRMWARE}/build_keyboard.mk" KEYBOARD="{keyboard_name}" KEYMAP="{cli.args.keymap}" REQUIRE_PLATFORM_KEY= COLOR=true SILENT=false {' '.join(cli.args.env)} \\
72+
+@$(MAKE) -C "{QMK_FIRMWARE}" -f "{QMK_FIRMWARE}/builddefs/build_keyboard.mk" KEYBOARD="{keyboard_name}" KEYMAP="{cli.args.keymap}" REQUIRE_PLATFORM_KEY= COLOR=true SILENT=false {' '.join(cli.args.env)} \\
7373
>>"{QMK_FIRMWARE}/.build/build.log.{os.getpid()}.{keyboard_safe}" 2>&1 \\
7474
|| cp "{QMK_FIRMWARE}/.build/build.log.{os.getpid()}.{keyboard_safe}" "{QMK_FIRMWARE}/.build/failed.log.{os.getpid()}.{keyboard_safe}"
7575
@{{ grep '\[ERRORS\]' "{QMK_FIRMWARE}/.build/build.log.{os.getpid()}.{keyboard_safe}" >/dev/null 2>&1 && printf "Build %-64s \e[1;31m[ERRORS]\e[0m\\n" "{keyboard_name}:{cli.args.keymap}" ; }} \\

lib/python/qmk/commands.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ def compile_configurator_json(user_keymap, bootloader=None, parallel=1, **env_va
213213
'-r',
214214
'-R',
215215
'-f',
216-
'build_keyboard.mk',
216+
'builddefs/build_keyboard.mk',
217217
])
218218

219219
if bootloader:

paths.mk

+3-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22
TOP_DIR = .
33
TMK_DIR = tmk_core
44
TMK_PATH = $(TMK_DIR)
5-
LIB_PATH = lib
5+
6+
LIB_DIR = lib
7+
LIB_PATH = $(LIB_DIR)
68

79
QUANTUM_DIR = quantum
810
QUANTUM_PATH = $(QUANTUM_DIR)

0 commit comments

Comments
 (0)