fix: describe works without Eventing

matejvasek · lance · commit 6c16e65d6054 · 2020-09-10T10:06:20.000-04:00
diff --git a/knative/describer.go b/knative/describer.go
@@ -2,6 +2,7 @@ package knative
 
 import (
 	"fmt"
+	"k8s.io/apimachinery/pkg/api/errors"
 
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/client-go/rest"
@@ -73,7 +74,8 @@ func (describer *Describer) Describe(name string) (description faas.Description,
 	}
 
 	triggers, err := eventingClient.Triggers(namespace).List(metav1.ListOptions{})
-	if err != nil {
+	// IsNotFound -- Eventing is probably not installed on the cluster
+	if err != nil && !errors.IsNotFound(err) {
 		return
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ package knative`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"fmt"`
	`5`	`+ "k8s.io/apimachinery/pkg/api/errors"`
`5`	`6`
`6`	`7`	`metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"`
`7`	`8`	`"k8s.io/client-go/rest"`
`@@ -73,7 +74,8 @@ func (describer *Describer) Describe(name string) (description faas.Description,`
`73`	`74`	`}`
`74`	`75`
`75`	`76`	`triggers, err := eventingClient.Triggers(namespace).List(metav1.ListOptions{})`
`76`		`- if err != nil {`
	`77`	`+ // IsNotFound -- Eventing is probably not installed on the cluster`
	`78`	`+ if err != nil && !errors.IsNotFound(err) {`
`77`	`79`	`return`
`78`	`80`	`}`
`79`	`81`