Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom builders #147

Merged
merged 4 commits into from
Oct 5, 2020
Merged

Custom builders #147

merged 4 commits into from
Oct 5, 2020

Conversation

matejvasek
Copy link
Contributor

No description provided.

lance
lance reviewed Oct 1, 2020
View reviewed changes
lance
lance reviewed Oct 1, 2020
View reviewed changes
matejvasek
matejvasek commented Oct 1, 2020
View reviewed changes
@matejvasek matejvasek requested a review from lance October 2, 2020 16:39
@matejvasek
Copy link
Contributor Author

@lance PTAL

lance
lance approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A couple of minor nits.

@matejvasek matejvasek changed the title WIP: Builders Custom builders Oct 2, 2020
@matejvasek matejvasek marked this pull request as ready for review October 2, 2020 19:40
@lance lance merged commit c2b4a30 into knative:main Oct 5, 2020
@lance lance mentioned this pull request Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matejvasek @lance