Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass CloudEvent data as first parameter for Node.js event fns #172

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

lance
Copy link
Member

@lance lance commented Oct 13, 2020

The 0.4.0 version of faas-js-runtime extracts the CloudEvent data from
an incoming event and provides that as the first parameter when invoking
a function which receives a CloudEvent. This commit bumps to that version
as well as improves the overall readability and code documentation for the
Node.js CloudEvent function.

Signed-off-by: Lance Ball lball@redhat.com

The 0.4.0 version of faas-js-runtime extracts the CloudEvent data from
an incoming event and provides that as the first parameter when invoking
a function which receives a CloudEvent. This commit bumps to that version
as well as improves the overall readability and code documentation for the
Node.js CloudEvent function.

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance added the templates/node Related to the Node.js function templates label Oct 13, 2020
@lance lance requested a review from a team October 13, 2020 19:00
@lance lance self-assigned this Oct 13, 2020
@lance lance changed the title feat: introduce CloudEvent data as first parameter for event functions feat: pass CloudEvent data as first parameter for Node.js event fns Oct 13, 2020
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance lance merged commit 7451194 into knative:main Oct 14, 2020
@lance lance deleted the nodejs-runtime-0.4.0 branch October 14, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
templates/node Related to the Node.js function templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants