feat!: rename faas to function

[zroubalik]

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

This PR renames:

• binary: faas -> function
• env variables: FAAS_ -> FUNCTION_
• config: faas.yaml -> func.yaml
• release registry: quay.io/boson/faas -> quay.io/boson/function

Fixes: #201

[lance]

release registry: quay.io/boson/faas -> quay.io/boson/faas

I assume this is a typo 😄

[zroubalik]

release registry: quay.io/boson/faas -> quay.io/boson/faas

I assume this is a typo 😄

Yeah :) I've updated the description

[lance]

Looks good with a few small changes. The big thing is that I should land #202 and you should rebase, then do pkger. The Node.js and Quarkus changes you have made here won't get picked up without it. :)

[zroubalik]

@lance thanks for the review, fixed

[lance]

@zroubalik lgtm - unless @rhuss has any concerns let's do it!

[rhuss]

Looks mostly good to me (but see my comments).

Alson not sure about that pkged.go file (can't add a comment there). What is this ?

Beside this (and reading the changes), I wonder whether we should add at least func as an alias as this is much shorter and would be a perfect drop-in replacement for faas when it comes to the length of the command. Also I would be in favor of a func.yaml over function.yaml.

[rhuss]

Is this file supposed to be part of this renaming PR ?

[zroubalik]

hm, don't know how does this end up here.

[zroubalik]

these files get modified after running make test. The deps needed to be updated.

[zroubalik]

@rhuss Thanks for the review. I have fixed the things from your comments, and renamed faas.yaml -> func.yaml.
func alias would be nice, but we can cover it in the separate PR imho, if we agree on it.

Is it ok to merge?

[rhuss]

looks good but there are still some references to function.yaml

[rhuss]

Thanks !

/lgtm
/approve