Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add spring cloud function runtime and templates #231

Merged
merged 3 commits into from
Nov 25, 2020
Merged

feat: add spring cloud function runtime and templates #231

merged 3 commits into from
Nov 25, 2020

Conversation

kameshsampath
Copy link
Contributor

  • Adds SpringBoot runtime based Spring Cloud Functions
  • Adds Spring Cloud Functions tempaltes for http and events

lance
lance reviewed Nov 25, 2020
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kameshsampath - thanks a lot for the contribution! This has really helped us move forward quite a bit! I have a bunch of nit picky requests (soon I will be known as the most annoying reviewer on GitHub!). And a couple of questions. Overall looks good. Thanks!

lance
lance approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kameshsampath!

@lance lance merged commit 557361a into knative:main Nov 25, 2020
@kameshsampath kameshsampath deleted the springboot-runtime branch November 25, 2020 19:06
@mattmoor
Copy link
Member

Y'all realize that quay.io/boson/faas-springboot-builder isn't an image? I see a :tip tag, but nothing else.

@kameshsampath
Copy link
Contributor Author

@mattmoor I think because of this boson-project/buildpacks#49 , I see thats not merged yet into the master

@mattmoor
Copy link
Member

@kameshsampath that merged, and there's still no :latest 🤔

@kameshsampath
Copy link
Contributor Author

@mattmoor I see the publish images in the CI is not being called for last few releases, wondering some bug with the GitHub release action ? I faced one such issue for one of my other projects and I have to bump the release action to latest to make it work .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kameshsampath @mattmoor @lance