Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix plugin version output #233

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Conversation

dsimansk
Copy link
Contributor

@lance @rhuss

The following code should retrieve and set the actual plugin's version based on go.mod definition. The required change/enhancement on kn's midstream is to use require correctly.

It seems a bit cleaner than setting another set of compile flags. Anyway the current set of flags is set through main package, so we'd need to change that to pass flags during kn's build.

E.g. from my hacks:

require (
	github.com/boson-project/faas v0.9.0
)

replace (
	github.com/boson-project/faas => /home/dsimansk/Git/boson-project/faas
)
➜  client git:(release-v0.17.3) ✗ kn func version
v0.9.0

@dsimansk dsimansk requested a review from a team November 30, 2020 20:55
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but let's wait for @lance review.

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good solution. Thanks @dsimansk !

Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 8a30ba1 into knative:main Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants