Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correcting broken merge #252

Merged
merged 1 commit into from
Dec 14, 2020
Merged

fix: correcting broken merge #252

merged 1 commit into from
Dec 14, 2020

Conversation

zroubalik
Copy link
Contributor

@zroubalik zroubalik commented Dec 14, 2020

PR #240 was somehow merged with unfinished git merge, see:
https://github.com/boson-project/func/blob/f0be048c841be22fcd0d448fdecc0da33b8c77be/cmd/list.go#L78-L87

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik zroubalik added kind/bug Categorizes issue or PR as related to a bug. source/commands labels Dec 14, 2020
@zroubalik zroubalik requested a review from a team December 14, 2020 13:06
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes! Thanks for the fix. :)

@lance lance merged commit 8d1f5b8 into knative:main Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants