-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add support for execution specifications #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm currently working on an implementation of this using my proposed syntax. I may do a simpler enhancement to learn the codebase before attempting it though. (probably won't) |
Sounds good to me. Changing the syntax should be easy as it is covered in
unit tests (which you should add to).
|
Progress so far, the following code generates the given sequence diagram:
TODO
@bramp Do you have any preferences when it comes to code style, esp with regard to line length? |
"@bramp Do you have any preferences when it comes to code style, esp with regard to line length?" no real preference, but keep it reasonable <80-120 ish. However, please run |
It would be great if support would be added for execution specifications, which are the thin grey rectangles which identify the beginning and end of an action being executed. Ideally we could support overlapping execution specifications too.
In websequencediagrams.com, the syntax used to denote execution specifications is by prepending the target actor with a
+
or-
, so the following sequence:Would be rendered like this:
I personally don't think this is a great syntax as when ending an execution you are using the
-
character on the other actor, which doesn't make a whole lot of sense. This also makes it impossible to do things like ending an execution on one lifeline and immediately beginning a new execution specification on the target actor, which is common with asynchronous communications.So I'm proposing we instead prepend the
+
or-
modifier to the lifeline/actor which is actually being modified, always, so the above example would actually be written as:Cheers!
The text was updated successfully, but these errors were encountered: