Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.10.0-beta.1: caddy version now prints additional log messages #6879

Closed
steffenbusch opened this issue Mar 6, 2025 · 3 comments
Closed
Assignees
Labels
bug 🐞 Something isn't working

Comments

@steffenbusch
Copy link
Contributor

Just used xcaddy to build v2.10.0-beta.1 and was suprised that caddy version now prints so much additional log messages:

$ ./caddy version
2025/03/06 21:52:34.510 INFO    maxprocs: Leaving GOMAXPROCS=1: CPU quota undefined
2025/03/06 21:52:34.512 INFO    GOMEMLIMIT is updated   {"package": "github.com/KimMachineGun/automemlimit/memlimit", "GOMEMLIMIT": 1582722662, "previous": 9223372036854775807}
v2.10.0-beta.1 h1:zo27fxsRBWQcFhEyddbCgcLngMZCi0lTKcA4gm926JQ=
2025/03/06 21:52:34.514 INFO    maxprocs: No GOMAXPROCS change to reset

Previously:

$ ./caddy version
v2.9.1 h1:OEYiZ7DbCzAWVb6TNEkjRcSCRGHVoZsJinoDR/n9oaY=

This also affects "caddy help" and other commands such as:

$ ./caddy list-modules --help
2025/03/06 21:58:53.957 INFO    maxprocs: Leaving GOMAXPROCS=1: CPU quota undefined
2025/03/06 21:58:53.959 INFO    GOMEMLIMIT is updated   {"package": "github.com/KimMachineGun/automemlimit/memlimit", "GOMEMLIMIT": 1582722662, "previous": 9223372036854775807}
Lists the installed Caddy modules

Usage:
  caddy list-modules [--packages] [--versions] [--skip-standard] [flags]

Flags:
  -h, --help            help for list-modules
      --packages        Print package paths
  -s, --skip-standard   Skip printing standard modules
      --versions        Print version information

Full documentation is available at:
https://caddyserver.com/docs/command-line
2025/03/06 21:58:53.964 INFO    maxprocs: No GOMAXPROCS change to reset
@mholt
Copy link
Member

mholt commented Mar 6, 2025

Yeah, it's a little annoying... maybe we can just run this if the CLI command is caddy run or caddy start. I don't think we need to adjust this if we're just printing debug info.

@mholt mholt added the bug 🐞 Something isn't working label Mar 6, 2025
@mholt mholt self-assigned this Mar 6, 2025
@mholt mholt closed this as completed in a686f7c Mar 6, 2025
@mholt mholt added this to the v2.10.0-beta.2 milestone Mar 6, 2025
@francislavoie
Copy link
Member

Alternatively, maybe the resource limits stuff should just be debug level, not info.

@mholt
Copy link
Member

mholt commented Mar 7, 2025

@francislavoie Just looked into it. We can do that for CPU, but for memory, it chooses the log level, so we can't change both unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants