Skip to content

feat: make icon adornment force focus on TextInput #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2020
Merged

feat: make icon adornment force focus on TextInput #1850

merged 2 commits into from
May 25, 2020

Conversation

matkoson
Copy link
Contributor

@matkoson matkoson commented Apr 21, 2020 •
edited
Loading

Motivation

  • discussion with @jbinda whether TextInput should be focused in case of IconAdornment being pressed on

paper-adornment-icon-focus

Test plan

@callstack-bot
Copy link

callstack-bot commented Apr 21, 2020 •
edited
Loading

Hey @matkoson, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@matkoson matkoson requested review from Trancever and jbinda April 21, 2020 11:47
@jbinda jbinda force-pushed the textinput-adornment branch from 8e3f8c5 to 2f742e3 Compare April 23, 2020 15:22
@jbinda jbinda changed the base branch from textinput-adornment to 4.0 May 13, 2020 13:15
@jbinda
Copy link
Contributor

jbinda commented May 13, 2020

I have rebased to 4.0 and will review later

@jbinda jbinda self-assigned this May 13, 2020
jbinda
jbinda reviewed May 14, 2020
View reviewed changes
Copy link
Contributor

@jbinda jbinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked and tested.

Looks nice. Have just one small adjustments and we are ready to go !

Good job @matkoson !

@jbinda
Copy link
Contributor

jbinda commented May 20, 2020

@Trancever I have resolved conversations and tested. It's ready to be merge

@Trancever Trancever merged commit 9e2e7f6 into callstack:4.0 May 25, 2020
@Alarees Alarees mentioned this pull request Jun 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbinda jbinda jbinda approved these changes

@Trancever Trancever Awaiting requested review from Trancever

Assignees

@jbinda jbinda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matkoson @callstack-bot @jbinda @Trancever