Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle check succeeds when it should fail on gem updates #130

Closed
kanmeiban opened this issue Nov 15, 2022 · 2 comments
Closed

bundle check succeeds when it should fail on gem updates #130

kanmeiban opened this issue Nov 15, 2022 · 2 comments

Comments

@kanmeiban
Copy link

It's more of an issue of bundler, still when updating a single gem bundle check succeeds while printing info about missing gem on STDERR. Fixed it with set :bundle_check_before_install, false. Maybe we should add a notice to the README?

From my capistrano.log:

 bundle check
 DEBUG [aae77348]       The following gems are missing
 * rugged (1.5.0.1)
 DEBUG [aae77348]       Install missing gems with `bundle install`
 DEBUG [aae77348] Finished in 1.202 seconds with exit status 0 (successful).
  INFO The Gemfile's dependencies are satisfied, skipping installation
@mattbrictson
Copy link
Member

Strange! I doubt this is a bundler issue. I found one upstream bug report but that ultimately was found to be due to a shell alias for bundler and not a bug in bundler itself: rubygems/rubygems#3233

Is it possible that bundle check is invoking an alias or wrapper script in your shell environment?

@kanmeiban
Copy link
Author

@mattbrictson, you're absolutely right. I'm actually running bundle check in a wrapper script (envkey-source) and it clobbers the return value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants