Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newest zen browser update 1.0.1-a.18 breaks theming. #11

Closed
undefinedcode0 opened this issue Nov 10, 2024 · 8 comments
Closed

Newest zen browser update 1.0.1-a.18 breaks theming. #11

undefinedcode0 opened this issue Nov 10, 2024 · 8 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@undefinedcode0
Copy link

Immediately after updating Zen, I noticed some elements not being themed (as far as I know) like the compact toolbar background, and correct me if I'm wrong, the browser background. Here are your Theme Changes that you should look out for and fix.

  • Compact mode will now use '--zen-main-browser-background-toolbar' as the background color
  • Browser background isn't defined on zen-main-app-wrapper element anymore but on the #browser element
  • Added a new variable for the translucency of the browser in macos"
@undefinedcode0
Copy link
Author

image

@undefinedcode0
Copy link
Author

image

@IAmJafeth IAmJafeth added bug Something isn't working good first issue Good for newcomers labels Nov 10, 2024
@IAmJafeth IAmJafeth self-assigned this Nov 10, 2024
@IAmJafeth
Copy link
Member

Hi @undefinedcode0,

I new something like this would happen when Mauro talked about this changes.

I am planing to review and asses this once I have some bandwidth.

Thanks for the report!

@undefinedcode0
Copy link
Author

Youre welcome, man! I'll be looking forward to the fix, I'll be waiting patiently! 👍

@IAmJafeth
Copy link
Member

Hey @undefinedcode0,

I was checking this and I can see that the Catppuccin Theme was not affected by the update.
It seems the variables I was using were not affected by this change.

The only thing that I can see that got 'broken' was the border around the Viewport, however this was an intentional change in this new Zen UI which deprecated it.

Adding --zen-main-browser-background-toolbar to has no effect, as this background was already themed using:

  #TabsToolbar {
        background-color: #181825 !important;
    }

And for the browser background --zen-themed-toolbar-bg along with --zen-colors-tertiary seems to be working just fine.

This theme is designed to be OS agnostic, therefore, it is not planned to support translucency for MacOS, this can be added by the user if wanted.

Let me know if I am not taking something in consideration, we can always reopen the issue if needed

@IAmJafeth IAmJafeth closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2024
@undefinedcode0
Copy link
Author

undefinedcode0 commented Nov 10, 2024

I forgot to mention that the Theme Changes were from the release notes so take it with a grain of salt. But, is there a way to theme the viewport again?

@IAmJafeth
Copy link
Member

IAmJafeth commented Nov 10, 2024

There must be a way tinkering with the CSS to bring the border back, however it is Catppuccin's philosophy to be a color scheme that does not modify the default behavior of the application.

So if Zen decided to go with this UI, the Catppuccin theme will not modify it.

Edit: Fixed typos

@undefinedcode0
Copy link
Author

Interesting... Thanks for acknowledging my issue though. I was wondering if there was a fix, but for now, there isn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants