refactor: range editing modal #3417
Merged
+107
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hamed-musallam
force-pushed
the
fix-adding-peak-crash-advance-mode
branch
from
8008493 to
910859a
Compare
Deploying nmrium with
|
| Latest commit: |
07f0118
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6625fb6a.nmrium.pages.dev |
| Branch Preview URL: | https://fix-adding-peak-crash-advanc.nmrium.pages.dev |
hamed-musallam
force-pushed
the
fix-adding-peak-crash-advance-mode
branch
from
910859a to
5d96da2
Compare
hamed-musallam
force-pushed
the
fix-adding-peak-crash-advance-mode
branch
from
5d96da2 to
dda1f10
Compare
hamed-musallam
force-pushed
the
fix-adding-peak-crash-advance-mode
branch
from
dda1f10 to
07f0118
Compare
|
Is this ready for review? |
|
@hamed-musallam Does this close an issue ? |
I'm waiting for Luc to test it |
Yes, it is supposed to. did you test it again? i'm not Ok with appending the singlet and Massive to the list of couplings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.