Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If there is no banner on page, skip link target is not valid #404

Open
richardgaunt opened this issue Oct 4, 2024 · 2 comments
Open

If there is no banner on page, skip link target is not valid #404

richardgaunt opened this issue Oct 4, 2024 · 2 comments
Assignees
@richardgaunt
Labels
State: Done The issue is complete and waiting for a release Type: Defect Issue is a defect
Milestone
1.9

Comments

@richardgaunt
Copy link
Collaborator

Summary

When there is no banner on page, skip link targets an invalid id.

Steps to reproduce

  1. Remove banner from page

Observed outcome

Note that skip link does not go anywhere on the page.

Expected outcome

Expect to be taken to main content.
@richardgaunt richardgaunt added the Type: Defect Issue is a defect label Oct 4, 2024
@richardgaunt
Copy link
Collaborator Author

#397 fixes this issue.
There are further fixes coming see: #355

@richardgaunt richardgaunt self-assigned this Oct 4, 2024
@sonamchaturvedi28
Copy link

Test Env: DEV
Test Status: PASS
Test Result:

  • When there is no banner on the page, the Skip link directs to main content.
Screen.Recording.2024-10-08.at.3.17.19.PM.mov

@fionamorrison23 fionamorrison23 added this to the 1.9 milestone Oct 23, 2024
@github-project-automation github-project-automation bot moved this to Todo in UI Kit Oct 23, 2024
@fionamorrison23 fionamorrison23 moved this from Todo to Done in UI Kit Oct 23, 2024
@fionamorrison23 fionamorrison23 added the State: Done The issue is complete and waiting for a release label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardgaunt richardgaunt

Labels
State: Done The issue is complete and waiting for a release Type: Defect Issue is a defect
Projects
UI Kit
Status: Done
Milestone
1.9
Development

No branches or pull requests
3 participants
@sonamchaturvedi28 @richardgaunt @fionamorrison23