Skip to content

Limited compatibility with go < 1.15.10 #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kernfeld-cockroach opened this issue Jul 7, 2021 · 4 comments
Closed

Limited compatibility with go < 1.15.10 #78

kernfeld-cockroach opened this issue Jul 7, 2021 · 4 comments

Comments

@kernfeld-cockroach
Copy link
Contributor

kernfeld-cockroach commented Jul 7, 2021

When one uses go < 1.15.10 to run go mod tidy, go mod vendor, and possible other go mod * commands in errors or any project that transitively depends on errors, one encounters a failure of the form:

> go mod tidy
github.com/cockroachdb/errors/errbase imports
	io/fs: package io/fs is not in GOROOT (/Users/paulkernfeld/.gvm/gos/go1.14/src/io/fs)

The following snippet from the Go Modules Reference might explain this behavior:

go mod tidy acts as if all build tags are enabled, so it will consider platform-specific source files and files that require custom build tags, even if those source files wouldn’t normally be built.

@kernfeld-cockroach
Copy link
Contributor Author

A correction: go mod tidy actually does work in go ≥ 1.15.10.

@knz hypothesizes that this is related to golang/go#46143

@kernfeld-cockroach kernfeld-cockroach changed the title Limited compatibility with go < 1.16 Limited compatibility with go < 1.15.10 Jul 7, 2021
@knz
Copy link
Contributor

knz commented Jul 28, 2021

Given that CI is happy with go 1.13 to 1.16, I'm going to close this issue.

@knz knz closed this as completed Jul 28, 2021
@kernfeld-cockroach
Copy link
Contributor Author

Given that CI is happy with go 1.13 to 1.16, I'm going to close this issue.

Are you saying that it's not important that users of this library be able to successfully run go mod tidy or go mod vendor? I find that counterintuitive because we often use those commands at Cockroach.

@knz
Copy link
Contributor

knz commented Jul 28, 2021

CI runs successfully with go 1.15.13. I am not too concerned with compatibility with 1.15.9 and prior if 1.15.13 works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants