Skip to content

Wrong height on quirks mode #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pomber opened this issue Mar 2, 2022 · 2 comments · Fixed by #143
Closed

Wrong height on quirks mode #140

pomber opened this issue Mar 2, 2022 · 2 comments · Fixed by #143

Comments

@pomber
Copy link
Contributor

pomber commented Mar 2, 2022

If the html doesn't have <!doctype ... >, browser renders it in quirks mode, and some of the height: 100% styles act weird.

image

Here's a minimal html to test with and without <!doctype> and see the difference:

<!DOCTYPE html>
<html>
  <body>
    <div>
      <p>Lorem</p>
      <div class="ch-cg">
        <div class="ch-code" style="height: 100%; background: rgb(46, 52, 64)">
          Hello
        </div>
      </div>
      <p>Lorem</p>
    </div>
  </body>
</html>
@sulco sulco mentioned this issue Mar 2, 2022
Closed
@pomber
Copy link
Contributor Author

pomber commented Mar 2, 2022 •
edited
Loading

Here's how the heigh: 100% works on quirk mode: The percentage height calculation quirk

@pomber pomber mentioned this issue Mar 3, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

🚀 Issue was released in v0.3.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix quirks mode height code-hike/codehike
1 participant
@pomber