Skip to content

Downloading updates from http source doesnt work #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XiDanko opened this issue Feb 20, 2022 · 6 comments · Fixed by #351
Closed

Downloading updates from http source doesnt work #309

XiDanko opened this issue Feb 20, 2022 · 6 comments · Fixed by #351

Comments

@XiDanko
Copy link

XiDanko commented Feb 20, 2022

when trying to download a release i get this error
cURL error 3: (see https://curl.haxx.se/libcurl/c/libcurl-errors.html) for http:update-server.localhostv1.0.1.zip
this is my env

SELF_UPDATER_VERSION_INSTALLED=1.0
SELF_UPDATER_SOURCE=http
SELF_UPDATER_PKG_FILENAME_FORMAT=v_VERSION_
SELF_UPDATER_REPO_URL=http://update-server.localhost/
SELF_UPDATER_DOWNLOAD_PATH=/tmp

it looks like your regular expression is deforming the repo url

@codedge
Copy link
Owner

codedge commented Mar 20, 2022

Can you show the complete output, the complete error message including stack trace?

@0ofland
Copy link

0ofland commented Apr 2, 2022

Can you show the complete output, the complete error message including stack trace?

I got the same error when using http source, thought I'd post here instead of opening a new issue.

Here's the error message, and stack trace: 
https://flareapp.io/share/NPL92qg7#F60

Edit:
Just to clarify, I don't think this has to do anything to do with us using localhost. i tried using a top level domain with and without SSL with the same result.

@0ofland
Copy link

0ofland commented Apr 5, 2022

Is there a way to use a GitHub release as the update source instead of the repository itself?

@codedge
Copy link
Owner

codedge commented Apr 27, 2022

Hmm.. sorry for the late response. There seems to be sth. weird with detecting the correct url. It would be nice to see what the output/response of your repository_url is that you specified via env var or in config/self-updater.php.

@codedge
Copy link
Owner

codedge commented Apr 27, 2022

Is there a way to use a GitHub release as the update source instead of the repository itself?
What do you mean whith that?

For GitHub, you can select a branch to update from or a release/tag.

@codedge
Copy link
Owner

codedge commented May 1, 2022

@0ofland @XiDanko

I found the issue and working on some fixes.

@codedge codedge linked a pull request May 1, 2022 that will close this issue
@codedge codedge closed this as completed May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants