Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/ fixed PageValidator console errors #2257

Merged
merged 4 commits into from
Mar 14, 2019
Merged

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Mar 13, 2019

The template was loaded with validator = undefined.

Description:

Thank you! 🚀


For contributor:

  • Added entries in PENDING.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #2257 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2257      +/-   ##
===========================================
- Coverage    96.67%   96.66%   -0.01%     
===========================================
  Files          108      108              
  Lines         2313     2312       -1     
  Branches       115      115              
===========================================
- Hits          2236     2235       -1     
  Misses          65       65              
  Partials        12       12
Impacted Files Coverage Δ
.../src/renderer/components/staking/PageValidator.vue 100% <ø> (ø) ⬆️

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #2257 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2257      +/-   ##
===========================================
- Coverage    96.68%   96.68%   -0.01%     
===========================================
  Files          108      108              
  Lines         2321     2320       -1     
  Branches       115      115              
===========================================
- Hits          2244     2243       -1     
  Misses          65       65              
  Partials        12       12
Impacted Files Coverage Δ
.../src/renderer/components/staking/PageValidator.vue 100% <ø> (ø) ⬆️

thx

Co-Authored-By: faboweb <frznhope@gmail.com>
jbibla
jbibla previously approved these changes Mar 13, 2019
@jbibla jbibla merged commit de369e3 into develop Mar 14, 2019
@jbibla jbibla deleted the fabo/fix-page-validator-error branch March 14, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants