-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fabo/ fixed PageValidator console errors #2257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2257 +/- ##
===========================================
- Coverage 96.67% 96.66% -0.01%
===========================================
Files 108 108
Lines 2313 2312 -1
Branches 115 115
===========================================
- Hits 2236 2235 -1
Misses 65 65
Partials 12 12
|
Codecov Report
@@ Coverage Diff @@
## develop #2257 +/- ##
===========================================
- Coverage 96.68% 96.68% -0.01%
===========================================
Files 108 108
Lines 2321 2320 -1
Branches 115 115
===========================================
- Hits 2244 2243 -1
Misses 65 65
Partials 12 12
|
fedekunze
reviewed
Mar 13, 2019
thx Co-Authored-By: faboweb <frznhope@gmail.com>
jbibla
previously approved these changes
Mar 13, 2019
fedekunze
approved these changes
Mar 13, 2019
jbibla
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template was loaded with
validator = undefined
.Description:
Thank you! 🚀
For contributor:
PENDING.md
with issue # and GitHub usernameFiles changed
in the github PR explorerFor reviewer: