Skip to content

Commit 057778c

Browse files
authored
fix: identification of duplicate @returns (#638)
1 parent bb7d201 commit 057778c

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

src/lib/AST/ParseJavadoc.cpp

+5-6
Original file line numberDiff line numberDiff line change
@@ -954,22 +954,21 @@ visitBlockCommandComment(
954954
case CommandTraits::KCI_returns:
955955
case CommandTraits::KCI_result:
956956
{
957-
doc::Returns returns;
958-
auto scope = enterScope(returns);
959-
// Scope scope(returns, block_);
960-
visitChildren(C->getParagraph());
961-
962957
auto itr = std::ranges::find_if(
963958
jd_.getBlocks(),
964959
[&](const std::unique_ptr<doc::Block> & b)
965960
{
966-
return b->kind != doc::Kind::returns;
961+
return b->kind == doc::Kind::returns;
967962
});
968963
if (itr != jd_.getBlocks().end())
969964
{
970965
report::warn("{}: Duplicate @returns statement", C->getBeginLoc().printToString(sm_));
971966
}
972967

968+
doc::Returns returns;
969+
auto scope = enterScope(returns);
970+
// Scope scope(returns, block_);
971+
visitChildren(C->getParagraph());
973972
jd_.emplace_back(std::move(returns));
974973
return;
975974
}

0 commit comments

Comments
 (0)