Export "types" for "require" too

[asamuzaK]

For example, in @csstools/css-calc package.json
It lacks "types" for cjs.

"exports": {
		".": {
			"import": {
				"types": "./dist/index.d.ts",
				"default": "./dist/index.mjs"
			},
			"require": {
				"default": "./dist/index.cjs"
			}
		}
	},

It causes error TS7016: Could not find a declaration file for module '@csstools/css-calc' when building with vite.
See: https://github.com/asamuzaK/cssColor/actions/runs/13327572771/job/37224110621#step:5:112

[lachlancollins]

More information here: https://publint.dev/rules#types_not_exported

Issue on Publint repo: publint/publint#160

[romainmenke]

Hi @asamuzaK @lachlancollins

That is not a bug.
We do not support types for commonjs.

see :

• packages provide wrong types under node16 module resolution #1031 (comment)
• If tsconfig.json is set to CommonJS mode, the declaration files cannot be read. #1303
• TypeScript error after upgrading postcss-preset-env from 9.3.0 to 9.4.0  #1295
• postcss-color-functional-notation doesn't expose TS types for CJS export #1217
• Postcss-nesting v12.0.4 is missing types field in package.json #1313

[lachlancollins]

That is not a bug. We do not support types for commonjs.

Hi @romainmenke , thanks for the reply, I didn't know there was a long context to this! ESM/CJS type resolution is a very complex and finicky issue I am well aware of.

I can see that tools like unbuild and tshy have been suggested before. The TanStack team now use our own tool, which is effectively just a shared Vite config which solves all of these problems we've encountered.

If you're open to it, I'd be happy to submit a draft PR to show what this would look like for this repo?

[romainmenke]

No we are not going to change our setup or built system.
In the (distant) future we will completely remove support for commonjs and move to pure es modules.

With support for es module imports from commonjs picking up this is the better way forward.

You can silence errors with things like @ts-expect-error

[lachlancollins]

With support for es module imports from commonjs picking up this is the better way forward.

Absolutely! Glad to hear :)