feat: rework test phases to make onSuccess default #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: now the onSuccess step is the default testing step, running the Cypress tests against the preview or production deploy. Another change is the default browser is Chromium instead of Electron.
BREAKING CHANGE: enable onSuccess hook, and disable other hooks.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
bahmutov
added a commit
to bahmutov/plugins
that referenced
this pull request
Mar 8, 2021
- run tests after deploy `onSuccess` by default - running tests `preBuild` and `postBuild` is opt-in - using bundled-in Chromium browser by default, it is more stable than Electron - tested across our example projects, see links cypress-io/netlify-plugin-cypress#133
5 tasks
erezrokah
pushed a commit
to bahmutov/plugins
that referenced
this pull request
May 16, 2021
- run tests after deploy `onSuccess` by default - running tests `preBuild` and `postBuild` is opt-in - using bundled-in Chromium browser by default, it is more stable than Electron - tested across our example projects, see links cypress-io/netlify-plugin-cypress#133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: now the onSuccess step is the default testing
step, running the Cypress tests against the preview or production
deploy. Another change is the default browser is Chromium instead
of Electron.
After merging and publishing the new NPM version